-
Notifications
You must be signed in to change notification settings - Fork 32
fix(expandable components): Add/update aria attributes to expandable components #3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+84
−34
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
ea3238b
added aria-expanded and aria-controls to Disclosure
LinKCoding c1991ca
update infotip aria attributes
LinKCoding b488938
added controls to listrow and expandcontrol
LinKCoding e7ba3ba
formatted
LinKCoding eb4bfc4
Merge branch 'main' into kl-gm-1006
LinKCoding 375c843
fix list story
LinKCoding c5c7894
remove minichevron icon from list stores
LinKCoding af644bd
updated drawer and flyout
LinKCoding e3a6542
formatted
LinKCoding 09dafab
updated drawer and flyout stories
LinKCoding 7b8a1b0
updated guidance on listrow
LinKCoding b8d36af
Merge branch 'main' into kl-gm-1006
LinKCoding d4851a7
formatted
LinKCoding b9d903e
omit id from DisclosureProps
LinKCoding 93c7be2
Merge branch 'main' into kl-gm-1006
LinKCoding 970247f
updated disclosure types
LinKCoding 416098d
formatted
LinKCoding f6dc0bc
updated disclosure to correct props and types
LinKCoding 2fe31e1
fix typo
LinKCoding 750cb72
Merge branch 'main' into kl-gm-1006
LinKCoding bba3aaf
clean up of useId
LinKCoding c1799a7
formatted
LinKCoding dd23d8f
updated disclosure body id
LinKCoding 978394f
fixed typo in id
LinKCoding bdaef81
Merge branch 'main' into kl-gm-1006
LinKCoding f37c7d5
pushing for build
LinKCoding b64c25f
updated disclosure to conditionally set aria-controls
LinKCoding ab014d2
Merge branch 'main' into kl-gm-1006
LinKCoding 699c116
re-implement useId()
LinKCoding 9bafa40
update drawer/flyout examples
LinKCoding 0499920
removed old comment and updated another
LinKCoding 89b1cd3
Merge branch 'main' into kl-gm-1006
LinKCoding 870787e
removed aria-controls from disclosure
LinKCoding 269659e
leftover code cleanup
LinKCoding 46bd453
Merge branch 'main' into kl-gm-1006
LinKCoding 93828de
feat(Modal)!: add multiview options for back and danger variant
aresnik11 75cd2ae
chore(release): publish
codecademy-gh-api 97e6c09
fix(modal + dialog): updating aria attributes per a11y team feedback
LinKCoding 588ac4b
chore(release): publish
codecademy-gh-api 6f2f7a0
cleaned up aria-controls
LinKCoding bb01462
more cleanup
LinKCoding 118ffff
formatted
LinKCoding 5f8463d
clean up list stories
LinKCoding ccb6094
Merge branch 'main' into kl-gm-1006
LinKCoding 6faca24
more clean up
LinKCoding d2239d2
update chevron color
LinKCoding cdf1572
Merge branch 'main' into kl-gm-1006
LinKCoding 8a23092
formatted
LinKCoding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this button used to have yellow text and now its grey. probably fine since this is just the storybook example but wanted to note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, thanks Amy — I should've left a comment.
That seems intentional based on what the original component, I'll ask Stacey just in case :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna update to
secondaryto match the textButton styling :) thanks again~