Skip to content

fix: upgrade svgo to latest version and make sure the comman uses recursive flag to traverse all files #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# EditorConfig is awesome: http://EditorConfig.org

root = true;
root = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check — Is this intentional? Did a formatting script do this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is intentional this was breaking for Neovim, lt looks like ; is not allowed on line ends


[*]
# Ensure there's no lingering whitespace
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@storybook/manager-api": "^8.3.6",
"@storybook/react-webpack5": "^8.3.6",
"@storybook/theming": "^8.3.6",
"@svgr/cli": "5.5.0",
"@svgr/cli": "^8.1.0",
"@testing-library/dom": "^8.11.1",
"@testing-library/jest-dom": "^5.16.1",
"@testing-library/react": "15.0.6",
Expand Down Expand Up @@ -88,7 +88,7 @@
"react-test-renderer": "18.3.1",
"storybook": "^8.3.6",
"style-loader": "^4.0.0",
"svgo": "^1.3.2",
"svgo": "^3.3.2",
"syncpack": "^10.9.3",
"ts-jest": "29.1.1",
"ts-node": "10.9.1",
Expand Down
9 changes: 0 additions & 9 deletions packages/gamut-icons/.svgo.yml

This file was deleted.

2 changes: 1 addition & 1 deletion packages/gamut-icons/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"repository": "git@github.com:Codecademy/gamut.git",
"scripts": {
"build": "nx build @codecademy/gamut-icons",
"format": "svgo -f ./src/svg --pretty --config=.svgo.yml"
"format": "svgo -rf ./src/svg --pretty --config=svgo.config.mjs"
},
"sideEffects": false,
"types": "dist/index.d.ts"
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion packages/gamut-icons/src/svg/mini/mini-add-icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion packages/gamut-icons/src/svg/mini/mini-arrow-up-icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading