chore: phpstan

Author: Soare-Robert-Daniel

includes/admin/feedzy-rss-feeds-log.php

@@ -270,9 +270,7 @@ public function set_context( array $context ) {
 	public static function log( $level, $message, array $context = array() ) {
 		try {
 			$instance = self::get_instance();
-			if ( $instance ) {
-				$instance->add_log_record( $level, $message, $context );
-			}
+			$instance->add_log_record( $level, $message, $context );
 		} catch ( Throwable $e ) {
 			if ( defined( 'WP_DEBUG' ) && WP_DEBUG ) {
 				error_log( sprintf( 'Feedzy_Rss_Feeds_Log error: %s', $e->getMessage() ) );
@@ -304,9 +302,9 @@ private function add_log_record( $level, $message, array $context = array() ) {
 		if ( ! isset( $merged_context['function'] ) || ! isset( $merged_context['line'] ) ) {
 			$origin = $this->get_calling_origin();
 			if ( ! isset( $merged_context['function'] ) ) {
-				$merged_context['function'] = is_array( $origin ) && isset( $origin['function'] ) ? $origin['function'] : (string) $origin;
+				$merged_context['function'] = $origin['function'];
 			}
-			if ( ! isset( $merged_context['line'] ) && is_array( $origin ) && isset( $origin['line'] ) ) {
+			if ( ! isset( $merged_context['line'] ) ) {
 				$merged_context['line'] = $origin['line'];
 			}
 		}
@@ -364,8 +362,9 @@ public function append_to_themeisle_log( $log_entry ) {
 			$formatted_message .= ' ' . wp_json_encode( $log_entry['context'], JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE );
 		}
 
-		$function_signature = isset( $log_entry['context']['function'] ) ? $log_entry['context']['function'] : 'unknown';
-		$line_number        = isset( $log_entry['context']['line'] ) ? $log_entry['context']['line'] : null;
+		$context            = isset( $log_entry['context'] ) && is_array( $log_entry['context'] ) ? $log_entry['context'] : array();
+		$function_signature = (string) ( $context['function'] ?? 'unknown' );
+		$line_number        = $context['line'] ?? null;
 
 		do_action( 'themeisle_log_event', FEEDZY_NAME, $formatted_message, $log_entry['level'], $function_signature, $line_number );
 	}
@@ -385,17 +384,17 @@ private function get_calling_origin() {
 			if ( isset( $frame['class'] ) && __CLASS__ === $frame['class'] ) {
 				continue;
 			}
-			if ( isset( $frame['function'] ) ) {
-				$func = isset( $frame['class'] )
-					? ( $frame['class'] . ( isset( $frame['type'] ) ? $frame['type'] : '::' ) . $frame['function'] . '()' )
-					: ( $frame['function'] . '()' );
-				$line = isset( $frame['line'] ) ? (int) $frame['line'] : null;
-
-				return array(
-					'function' => $func,
-					'line'     => $line,
-				);
-			}
+
+			$function_name = $frame['function'];
+			$func          = isset( $frame['class'] )
+				? ( $frame['class'] . ( isset( $frame['type'] ) ? $frame['type'] : '::' ) . $function_name . '()' )
+				: ( $function_name . '()' );
+			$line          = isset( $frame['line'] ) ? (int) $frame['line'] : null;
+
+			return array(
+				'function' => $func,
+				'line'     => $line,
+			);
 		}
 		return array(
 			'function' => 'unknown',

includes/layouts/feedzy-logs-viewer.php

@@ -6,7 +6,7 @@
 
 $all_filter_url = admin_url( 'admin.php?page=feedzy-settings&tab=logs' );
 
-$logs_type_filter = isset( $_REQUEST['logs_type'] ) ? strtoupper( sanitize_text_field( wp_unslash( $_REQUEST['logs_type'] ) ) ) : null; // phpcs:ignore WordPress.Security.NonceVerification
+$logs_type_filter = isset( $_REQUEST['logs_type'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['logs_type'] ) ) : null; // phpcs:ignore WordPress.Security.NonceVerification
 
 $log_types = array(
 	'debug'   => __( 'Debug', 'feedzy-rss-feeds' ),