Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a change to the theme configuration setup to remove the use of italics for specific operators. These operators include the type assignment colon (
:
), the value assignment equal sign (=
), and logical operators (e.g.,&&
,||
,!
, etc.).The purpose of this change is to improve the readability and consistency of the code, as some users find italics difficult to read or distracting. Additionally, removing italics from these operators aligns with common style guides and conventions, allowing for a more uniform experience across various projects.
The modifications include updates to the theme's JSON file, specifically in the
tokenColors
array where each operator's styling is defined. ThefontStyle
property for these operators has been updated to exclude the "italic" value.Summary of changes:
This Pull Request may be considered somewhat opinionated, as the choice of using italics for specific operators is often a matter of personal preference. However, I believe that this change can provide a net positive impact on the readability and consistency of the code for the majority of our team members. To help illustrate the differences and potential benefits, I have included before and after screenshots to showcase the updated theme configuration:
Before
After
Thanks in advance!