Fix fuzzy command search not ignoring blacklisted users #6594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Category: Core - Other Internals
Flame442
added
the
Type: Bug
Jackenmen
requested changes
Aug 26, 2025
There was a problem hiding this comment.
This does technically solve the specific issue that it aims to, but the true reason this is happening is that the bot's global checks are not called - you can observe the same problem with e.g. the ignore list:
We could instead check the output of bot.message_eligible_as_command, but that may still be a band-aid fix? i.e. other cogs could be adding their own checks that wouldn't be called then (but then, on the other hand, maybe they shouldn't, since such checks might not expect the provided context to have no command? + we would deviate quite a bit from d.py's behaviour, if we called these checks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Fixes fuzzy command search not ignoring blacklisted users
Closes #6482
Have the changes in this PR been tested?
Yes