Remove shared libraries feature from Downloader#6741
Open
Jackenmen wants to merge 1 commit intoCog-Creators:V3/developfrom
Open
Remove shared libraries feature from Downloader#6741Jackenmen wants to merge 1 commit intoCog-Creators:V3/developfrom
Jackenmen wants to merge 1 commit intoCog-Creators:V3/developfrom
Conversation
github-actions
Bot
added
Category: Cogs - Downloader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Those goddamn libs keep popping up in my code, I want them to stop! (/s)
It's time to get rid of this functionality. We've successfully discouraged people from using these with all the deprecation notices, and there's a real maintenance burden in keeping this feature alive. More so, the meta path hook is not entirely free, even if, realistically, the performance penalty cannot possibly be noticeable to anyone.
Before Red 3.6 releases, there will be a new incompatible changes document for 3.6, and I'll move the section from the "Future changes" document then.
Have the changes in this PR been tested?
No