-
Notifications
You must be signed in to change notification settings - Fork 748
Update documentation #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update documentation #364
Conversation
|
@dalthviz would you take a look at these updates to see if I'm missing something or got anything wrong? |
dalthviz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @conradolandia ! Left some initial suggestions/comments (a suggestion for a table with a duplicated column) and a comment on the documentation regarding the usage of load_stylesheet (I think that function doesn't support custom palettes).
Co-authored-by: Daniel Althviz Moré <16781833+dalthviz@users.noreply.github.com>
|
Thank you for your suggestions, @dalthviz! I fully rewrote |
From my check, although the public function QDarkStyleSheet/qdarkstyle/__init__.py Lines 240 to 252 in 6f3962e
In that function, if you pass as So basically |
|
Thanks for your comments @dalthviz, this is again ready for review! |
dalthviz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @conradolandia ! Left some further comments/suggestions
Co-authored-by: Daniel Althviz Moré <16781833+dalthviz@users.noreply.github.com>
…ts descriptions. Add explicit documentation about the creation of Dark and Light variations for custom themes
|
Thanks @dalthviz, I updated the documentation taking into account your comments, updated CONTRIBUTING.rst and also added a new file with a demo for custom theme creation. |
Co-authored-by: Daniel Althviz Moré <16781833+dalthviz@users.noreply.github.com>
…run_ui_css_edition.py`
This PR improves QDarkStyleSheet documentation to reflect recent API changes and address missing user guidance.
Changes made:
Enhanced Main API Documentation (
qdarkstyle/__init__.py):paletteparameter inload_stylesheet()pysideparameter as deprecatedComplete Palette System Documentation (
docs/color_reference.rst):Custom Palettes Creation Guide (
docs/custom_palettes.rst):Utils CLI Documentation (
docs/scripts/qdarkstyle_utils.rst):python -m qdarkstyle.utilscommand-line interfaceTechnical improvements:
Impact: