http:Sessions are not reused in practice #11576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we could drop the support for that and enable simplifying e.g. always do asyncShutdown automatically and remove the need for callers to do that. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ic1c66efce5f6e68e3c375ce30e0440eb24e0e01e
caolanm
force-pushed
the
private/caolan/http_session_never_reused
branch
from
74af8fa to
fd11197
Compare
|
Are we re-using TCP Sockets to serve multiple requests still I wonder ? =) hopefully there are tests for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we could drop the support for that and enable simplifying
e.g. always do asyncShutdown automatically and remove the need for callers to do that.
Change-Id: Ic1c66efce5f6e68e3c375ce30e0440eb24e0e01e
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay