Consolidated Sidebar and Navigator Panel Styles #11636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CodingwithKetan <ghoriketan33@gmail.com> Change-Id: I4fef639bc88c5a74fbbc9ddaa19954ae96b069b9
Darshan-upadhyay1110
requested review from
Darshan-upadhyay1110 and
pedropintosilva
pedropintosilva
approved these changes
May 2, 2025
|
Thank you @CodingwithKetan for the improvements! It looks good and I have tested. I have noticed that there is no space before the opening curly brace but then again we don't seem to have anything enforcing ( I see other CSS declarations with no space from other commits as well, maybe a good new easy hack, will create one) |
|
@CodingwithKetan added new easy hack :) #11824 |
|
COOL 25.04 unit tests w/o cypress |
pedropintosilva
merged commit a9f10a3
into
CollaboraOnline:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I4fef639bc88c5a74fbbc9ddaa19954ae96b069b9
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay