Skip to content

cid#398530 Overflowed integer argument #11708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

caolanm
Copy link
Contributor

@caolanm caolanm commented Apr 22, 2025

It is surprisingly difficult to satisfy coverity of the correctness of a read/write loop. This pattern works.

Change-Id: Id43c63050b0ea8debf336f8bb31af8cf3591d459

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

It is surprisingly difficult to satisfy coverity of the correctness
of a read/write loop. This pattern works.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id43c63050b0ea8debf336f8bb31af8cf3591d459
@caolanm
Copy link
Contributor Author

caolanm commented Apr 25, 2025

This is similar to #11696 and is meant to be equivalent, just reformulated in a way to get past overlapping coverity checkers

Copy link
Contributor

@vmiklos vmiklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like how the retry logic is now in a separate function, so it's a detail to be ignored in FileUtil::copy().

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Apr 28, 2025
@vmiklos vmiklos merged commit 7d3684d into master Apr 28, 2025
14 checks passed
@vmiklos vmiklos deleted the private/caolan/coverity20250422 branch April 28, 2025 06:32
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants