Skip to content

hackweek : improve performance/memory for webgl #11743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 1, 2025
Merged

hackweek : improve performance/memory for webgl #11743

merged 6 commits into from
May 1, 2025

Conversation

codewithvk
Copy link
Contributor

…ture storage

Change-Id: I27088679ff66652c453e18cb131ca185946d6941

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@codewithvk codewithvk force-pushed the private/codewithvk/hackweek branch from 81534d3 to c399397 Compare April 29, 2025 13:14
@codewithvk codewithvk marked this pull request as ready for review April 30, 2025 04:33
@mmeeks mmeeks requested a review from Cwiiis April 30, 2025 09:01
@mmeeks
Copy link
Contributor

mmeeks commented Apr 30, 2025

Chris - our presentation story is very mixed; can you help review this stuff & get it merged. Also - it would be really useful for you to have a call with @codewithvk RSN to take and dissect a profile of the presentation start: there are some quite amazing things going on there, and I hope web-workers could help a lot de-compressing big screen-sized images etc.

Cwiiis
Cwiiis reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

@Cwiiis Cwiiis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have too many questions to give explicit approval, but the general gist is good - essentially, stop spamming glGetLocation.

For what it's worth, this is probably cached when using ANGLE (the WebGL backend used in Chrome and Firefox), but this is still a good idea, we have much more information than the browser to know when our cached state is valid.

@Cwiiis
Copy link
Contributor

Cwiiis commented Apr 30, 2025

Chris - our presentation story is very mixed; can you help review this stuff & get it merged. Also - it would be really useful for you to have a call with @codewithvk RSN to take and dissect a profile of the presentation start: there are some quite amazing things going on there, and I hope web-workers could help a lot de-compressing big screen-sized images etc.

Sure - @codewithvk, probably best to catch me after a meeting - so around Tuesday 10:00 or Wednesday 11:30 (UTC+1)

@codewithvk codewithvk requested a review from Cwiiis April 30, 2025 12:14
@codewithvk codewithvk force-pushed the private/codewithvk/hackweek branch from 4c9995a to e47ad70 Compare April 30, 2025 12:15
Cwiiis
Cwiiis approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@Cwiiis Cwiiis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations/updates - lgtm!

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Apr 30, 2025
@codewithvk
Copy link
Contributor Author

Thanks @Cwiiis for the review. CI is failing for JSCPCD, looking into it.

@codewithvk codewithvk force-pushed the private/codewithvk/hackweek branch from b709924 to c5ffc20 Compare April 30, 2025 13:39
codewithvk added 6 commits May 1, 2025 00:05
@codewithvk
refactor(transition3d): switch PermTextureTransition to immutable tex…
6bca0ff 
…ture storage

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: I27088679ff66652c453e18cb131ca185946d6941
@codewithvk
refactor(transition2d): cache uniform locations
2a8c3fb 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: Ifc20d52fdce320474a169760a25d7490e74b5c9c
@codewithvk
fix(canvas-loader): cache uniforms
43b4bd2 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: Idd8fc2a10fb7374dbfc998904b8b06880af70070
@codewithvk
fix(webgl-video): initialize and cache program before first video render
3cd053a 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: I454cfbd7e29c397d04569eb539a6a8aea1854f29
@codewithvk
refactor(slideshow): replace uniform cache with js Map
ff68238 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: I7964916a8ddbc0e3efd6483e82cbf043209fbacb
@codewithvk
refactor(slideshow): extract color uniform logic into computeColor
63f13d1 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: I5fe84e0fed6f8fec09901b1a7b6351c2768ed4b0
@codewithvk codewithvk force-pushed the private/codewithvk/hackweek branch from c5ffc20 to 63f13d1 Compare April 30, 2025 18:36
@codewithvk codewithvk merged commit 12a319d into CollaboraOnline:master May 1, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cwiiis Cwiiis Cwiiis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Collabora Online
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codewithvk @mmeeks @Cwiiis