Skip to content

Private/caolan/shrink admin documents #11747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

caolanm
Copy link
Contributor

@caolanm caolanm commented Apr 25, 2025

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

Poco::URI is a lot larger than the two strings we need it for

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id580359ad7eeb6d5002fbfb969177e93718a21ab
the key is the current time which will be >= the last time so
just store the time of the last snapshot to compare the current
one to.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I8609d75f4ba8fe91a8896be79fe4da3fffcf777d
@caolanm caolanm force-pushed the private/caolan/shrink_admin_documents branch from 7363272 to 879d40d Compare April 25, 2025 13:43
@caolanm caolanm requested a review from Ashod April 25, 2025 14:59
Copy link
Contributor

@mmeeks mmeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me =) thanks.

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Apr 28, 2025
@mmeeks mmeeks merged commit 0bddb5b into master Apr 28, 2025
14 checks passed
@mmeeks mmeeks deleted the private/caolan/shrink_admin_documents branch April 28, 2025 10:14
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants