report fixed wavelength in emission spec #152
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-idiris
force-pushed
the
update-emission-layout-reporting-format
branch
from
913dbc7 to
2c00d26
Compare
src/helpers/format.js
Outdated
| }, | ||
| ); | ||
| // eslint-disable-next-line prefer-destructuring | ||
| fixedWavelength = jcamp.info.$CSAUTOMETADATA.match(/FIXEDWAVELENGTH=([\d.]+)/)[1]; |
There was a problem hiding this comment.
- What will happen when
CSAUTOMETADATAis not in the jcamp file? - What will happen when
FIXEDWAVELENGTHis not in the jcamp file?
f-idiris
force-pushed
the
update-emission-layout-reporting-format
branch
from
c3d0ca0 to
4544297
Compare
f-idiris
force-pushed
the
update-emission-layout-reporting-format
branch
from
d24c2e7 to
85d4718
Compare
baolanlequang
force-pushed
the
development
branch
from
6c835f3 to
e401ab1
Compare
baolanlequang
force-pushed
the
development
branch
from
766742c to
bf95f7d
Compare
baolanlequang
force-pushed
the
development
branch
from
bf95f7d to
cf56166
Compare
baolanlequang
force-pushed
the
development
branch
from
cf56166 to
b8cb082
Compare
baolanlequang
force-pushed
the
development
branch
4 times, most recently
from
e189b84 to
df4eaa0
Compare
baolanlequang
force-pushed
the
development
branch
from
df4eaa0 to
4cb3ae4
Compare
baolanlequang
force-pushed
the
development
branch
from
42fa155 to
7cc45e2
Compare
baolanlequang
force-pushed
the
development
branch
from
6331f2d to
725f79f
Compare
baolanlequang
force-pushed
the
development
branch
from
33a6123 to
afb52d1
Compare
baolanlequang
force-pushed
the
development
branch
from
168ada3 to
1c80817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.