Feature/8316 improve callback verification

[jf-cbd]

Internal

Base information

Question	Answer
Related to a SourceForge thead / Another PR / Combodo ticket?	N°8316
Type of change?	Enhancement

Symptom (bug) / Objective (enhancement)

Callback functions can actually be called even if their signature is incorrect, which can lead to unexpected behaviors.

Reproduction procedure (bug)

1. On iTop 3.2.1
2. With the included module of combodo-webhook-integration
3. With PHP 8.3
4. Set up a webhook with a callback having a signature that is not the expected one
5. Then trigger the webhook
6. Finally, see that the callback have been called

Cause (bug)

There is actually no check on the callback signature

Proposed solution (bug and enhancement)

• Perform a check on the callback signature
• Reactor code to process the 2 different callbacks (the one for payload and on the after receiving the response) at the same place

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• Would a unit test be relevant and have I added it?
• Is the PR clear and detailed enough so anyone can understand without digging in the code?

[Hipska]

One suggestion to be even more sure about class names..

[jf-cbd]

One suggestion to be even more sure about class names..

Done, thanks for the suggestion :)