Skip to content

Modify the structure to be installable via pip and support new UI #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Apr 9, 2025

This PR is meant to be paired with:

This PR is based on branch:

TODO:

  • Disable eager requests made by legacy manager FE code
  • Publish initial version to pypi manually for easier testing
  • Test
    • Test: Using all legacy UI features
    • Test: Using every single feature and manager API endpoint with the full e2e setup
    • Test: Using with --disable-manager arg
    • Test: Using when manager custom node is still on user system
    • Test: ComfyUI updated but comfyui-frontend-package was not
    • Test: Using --disable-manager arg then loading manager as a custom node

@christian-byrne christian-byrne marked this pull request as ready for review April 9, 2025 23:15
@christian-byrne christian-byrne requested a review from ltdrdata April 9, 2025 23:37
@christian-byrne
Copy link
Contributor Author

christian-byrne commented Apr 10, 2025

PyPI package version 4.0, based on this branch:

https://pypi.org/project/comfyui-manager/4.0/

@ltdrdata
Copy link
Member

This is moved to draft-v4
#1737

@ltdrdata ltdrdata closed this Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants