refactor: Change manager flag from --disable-manager to --enable-manager #5635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated useManagerState to check for --enable-manager flag presence - Inverted logic: manager is now disabled by default unless --enable-manager is present - Updated all related tests to reflect the new opt-in behavior - Aligns with backend changes in ComfyUI core PR #7555
- When systemStats is null, --enable-manager flag cannot be checked - Manager should be disabled in this case as the flag is not present - Updated test expectation to reflect correct behavior
dosubot
bot
added
the
size:M
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/18/2025, 01:08:04 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
approved these changes
Sep 18, 2025
christian-byrne
added
needs-backport
christian-byrne
approved these changes
Sep 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
…ger (#5635) ## Summary - Updated frontend to align with backend changes in ComfyUI core PR #7555 - Changed manager startup argument from `--disable-manager` (opt-out) to `--enable-manager` (opt-in) - Manager is now disabled by default unless explicitly enabled ## Changes - Modified `useManagerState.ts` to check for `--enable-manager` flag presence - Inverted logic: manager is disabled when the flag is NOT present - Updated all related tests to reflect the new opt-in behavior - Fixed edge case where `systemStats` is null ## Related - Backend PR: comfyanonymous/ComfyUI#7555 ## Test Plan - [x] All unit tests pass - [x] Verified manager state logic with different flag combinations - [x] TypeScript type checking passes - [x] Linting passes 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5635-refactor-Change-manager-flag-from-disable-manager-to-enable-manager-2726d73d36508153a88bd9f152132b2a) by [Unito](https://www.unito.io)
|
@viva-jinyi Successfully backported to #5639 |
christian-byrne
pushed a commit
that referenced
this pull request
Sep 18, 2025
…to --enable-manager (#5639) Backport of #5635 to `core/1.26` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5639-backport-1-26-refactor-Change-manager-flag-from-disable-manager-to-enable-manager-2726d73d36508120a29fcaefd91dbf40) by [Unito](https://www.unito.io) Co-authored-by: Jin Yi <jin12cc@gmail.com>
christian-byrne
added
needs-backport
Merged
christian-byrne
added a commit
that referenced
this pull request
Sep 18, 2025
## What's Changed ### 🐛 Bug Fixes - Change manager flag from --disable-manager to --enable-manager to align with backend changes (#5635) This hotfix ensures frontend compatibility with ComfyUI core PR #7555, changing the manager startup behavior from opt-out to opt-in. **Full Changelog**: v1.26.11...v1.26.12 EOF < /dev/null ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5641-Release-v1-26-12-2726d73d36508141aae1efa8f2bc4b08) by [Unito](https://www.unito.io)
christian-byrne
added
needs-backport
christian-byrne
pushed a commit
that referenced
this pull request
Sep 19, 2025
…ger (#5635) ## Summary - Updated frontend to align with backend changes in ComfyUI core PR #7555 - Changed manager startup argument from `--disable-manager` (opt-out) to `--enable-manager` (opt-in) - Manager is now disabled by default unless explicitly enabled ## Changes - Modified `useManagerState.ts` to check for `--enable-manager` flag presence - Inverted logic: manager is disabled when the flag is NOT present - Updated all related tests to reflect the new opt-in behavior - Fixed edge case where `systemStats` is null ## Related - Backend PR: comfyanonymous/ComfyUI#7555 ## Test Plan - [x] All unit tests pass - [x] Verified manager state logic with different flag combinations - [x] TypeScript type checking passes - [x] Linting passes 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5635-refactor-Change-manager-flag-from-disable-manager-to-enable-manager-2726d73d36508153a88bd9f152132b2a) by [Unito](https://www.unito.io)
christian-byrne
added a commit
that referenced
this pull request
Sep 19, 2025
Cherry-pick of PR #5635: refactor: Change manager flag from --disable-manager to --enable-manager ## Summary - Cherry-picked commit a41b8a6 - Updates frontend to align with backend changes in ComfyUI core PR #7555 - Changed manager startup argument from `--disable-manager` (opt-out) to `--enable-manager` (opt-in) - Manager is now disabled by default unless explicitly enabled ## Original Changes - Modified `useManagerState.ts` to check for `--enable-manager` flag presence - Inverted logic: manager is disabled when the flag is NOT present - Updated all related tests to reflect the new opt-in behavior - Fixed edge case where `systemStats` is null ## Testing - ✅ TypeScript type checking passed - ✅ ESLint linting passed - ✅ Prettier formatting passed - ✅ Knip found no issues - ✅ Cherry-pick applied cleanly with no conflicts ## Related - Original PR: #5635 - Backend PR: comfyanonymous/ComfyUI#7555 This hotfix ensures the frontend manager flag logic matches the backend changes. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5646-backport-Cherry-pick-manager-flag-refactor-to-core-1-27-2736d73d365081d38d8fddd6e451e156) by [Unito](https://www.unito.io) Co-authored-by: Jin Yi <jin12cc@gmail.com>
Myestery
pushed a commit
that referenced
this pull request
Sep 19, 2025
…ger (#5635) ## Summary - Updated frontend to align with backend changes in ComfyUI core PR #7555 - Changed manager startup argument from `--disable-manager` (opt-out) to `--enable-manager` (opt-in) - Manager is now disabled by default unless explicitly enabled ## Changes - Modified `useManagerState.ts` to check for `--enable-manager` flag presence - Inverted logic: manager is disabled when the flag is NOT present - Updated all related tests to reflect the new opt-in behavior - Fixed edge case where `systemStats` is null ## Related - Backend PR: comfyanonymous/ComfyUI#7555 ## Test Plan - [x] All unit tests pass - [x] Verified manager state logic with different flag combinations - [x] TypeScript type checking passes - [x] Linting passes 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5635-refactor-Change-manager-flag-from-disable-manager-to-enable-manager-2726d73d36508153a88bd9f152132b2a) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--disable-manager(opt-out) to--enable-manager(opt-in)Changes
useManagerState.tsto check for--enable-managerflag presencesystemStatsis nullRelated
Test Plan
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito