Add frontend setup composite action to reduce workflow duplication #5805
+79
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright Test Results⏰ Completed at: 09/27/2025, 03:22:36 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
dosubot
bot
added
the
size:M
DrJKL
requested changes
Sep 26, 2025
Comment on lines
+28
to
+33
| - name: Checkout ComfyUI_devtools | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: 'Comfy-Org/ComfyUI_devtools' | ||
| path: 'ComfyUI/custom_nodes/ComfyUI_devtools' | ||
| ref: ${{ inputs.devtools_ref }} |
There was a problem hiding this comment.
We're not checking out devtools anymore, it's in the monorepo now.
| using: 'composite' | ||
| steps: | ||
| - name: Checkout ComfyUI | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
question: Are we not able to use v5?
| pip install wait-for-it | ||
| - name: Build & Install ComfyUI_frontend | ||
| shell: bash |
There was a problem hiding this comment.
Suggested change
| shell: bash |
| pnpm build | ||
| - name: Start ComfyUI server | ||
| shell: bash |
There was a problem hiding this comment.
Suggested change
| shell: bash |
| python-version: '3.10' | ||
|
|
||
| - name: Install Python requirements | ||
| shell: bash |
There was a problem hiding this comment.
Suggested change
| shell: bash |
| with: | ||
| repository: 'comfyanonymous/ComfyUI' | ||
| path: 'ComfyUI' | ||
| ref: 'master' |
There was a problem hiding this comment.
optional: If you don't set ref, it'll pick the default branch for you.
Similar to the Playwright composite action, this moves the frontend setup logic from the external Comfy-Org/ComfyUI_frontend_setup_action into a local composite action at .github/actions/setup-frontend. Benefits: - Reduces external dependencies - Allows easier customization and maintenance - Consistent with the Playwright composite action pattern - Provides better control over versioning and updates Updated workflows: - i18n.yaml - i18n-node-defs.yaml - test-browser-exp.yaml The new composite action provides the same functionality as the external action with additional flexibility through configurable inputs for paths, versions, and conditional steps.
Reduced inputs from 9 to 2, matching the original ComfyUI_frontend_setup_action: - extra_server_params: Additional server parameters - devtools_ref: Reference for ComfyUI_devtools Removed unnecessary configurability that added complexity without value. The action now directly mirrors the external action's simplicity.
DrJKL
force-pushed
the
sno-frontend-setup-action
branch
from
623434f to
d00f047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.github/actions/setup-frontendto replace the externalComfy-Org/ComfyUI_frontend_setup_actionMotivation
Similar to the Playwright composite action, this change:
Changes
New composite action:
.github/actions/setup-frontend/action.ymlDirect mirror of the external action with the same 2 inputs:
extra_server_params: Additional parameters to pass to ComfyUI serverdevtools_ref: Reference to use for ComfyUI_devtoolsThe action:
Updated workflows:
.github/workflows/i18n.yaml.github/workflows/i18n-node-defs.yaml.github/workflows/test-browser-exp.yamlAll workflows now use the local composite action instead of
Comfy-Org/ComfyUI_frontend_setup_action@v3Test plan
Related PRs
🤖 Generated with Claude Code