Use workspace in knip config #5809
Merged
+19
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎭 Playwright Test Results⏰ Completed at: 09/27/2025, 01:34:34 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
approved these changes
Sep 27, 2025
| project: ['src/**/*.{js,ts}'] | ||
| }, | ||
| 'packages/design-system': { | ||
| entry: ['src/**/*.ts'], |
There was a problem hiding this comment.
You might be able to limit this to a single entry file.
Usually an index that exports specific pieces.
christian-byrne
added a commit
that referenced
this pull request
Sep 27, 2025
## Summary
After the `pnpm`/`Nx` monorepo migration, `knip` emitted configuration
hints like “Remove or move unused top-level entry…/project…” because it
discovered multiple workspaces but our config still declared global
`entry`/`project` patterns:
```
> knip --cache
Configuration hints (4)
Remove or move unused top-level entry to one of workspaces: [{build,scripts}/**/*.{js,ts}, …]
Remove or move unused top-level project to one of workspaces: [**/*.{js,ts,vue}, …]
Remove from ignoreBinaries: only-allow
Remove from ignoreBinaries: openapi-typescript
```
Rewriting `knip.config.ts` to define those patterns inside the
`workspaces` map for `'.'`, `packages/tailwind-utils`, and
`packages/design-system` matches Knip’s documented workspace schema
(root key `'.'` plus per-package overrides) and aligns each package’s
source with the files it actually exposes.
Follow-up: trim `packages/design-system` entries to the real public
surface, add a wildcard workspace default for future packages, and
capture this expectation somewhere in the repo's docs.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5809-Use-workspace-in-knip-config-27b6d73d365081b8ace9c82aee78b1db)
by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the
pnpm/Nxmonorepo migration,knipemitted configuration hints like “Remove or move unused top-level entry…/project…” because it discovered multiple workspaces but our config still declared globalentry/projectpatterns:Rewriting
knip.config.tsto define those patterns inside theworkspacesmap for'.',packages/tailwind-utils, andpackages/design-systemmatches Knip’s documented workspace schema (root key'.'plus per-package overrides) and aligns each package’s source with the files it actually exposes.Follow-up: trim
packages/design-systementries to the real public surface, add a wildcard workspace default for future packages, and capture this expectation somewhere in the repo's docs.┆Issue is synchronized with this Notion page by Unito