Extract Zod schemas into shared workspace package #5810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
🎭 Playwright Test Results⏰ Completed at: 09/27/2025, 02:35:14 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
|
Changed this to draft. There are translations being hard-coded in |
This was referenced Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate Zod schemas to a shared
@comfyorg/schemaspackage to enable reuse across workspace packages while maintaining backward compatibility through re-exports.Changes
@comfyorg/schemasworkspace package and migrated all Zod schemas fromsrc/schemas/to the new packageReview Focus
The migration uses re-exports to maintain 100% backward compatibility - no import changes needed in consuming code. The git history is preserved through
git mvoperations.The diff of this PR is massive, as the files were moved then replaced by re-export files (tracking issue will be created to remove these). The links below show the actual changes in the PR much more cleanly.