[fix] add InputSlot and dot error state #5813
Conversation
dosubot
bot
added
the
size:L
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 09/28/2025, 12:01:22 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
| const hasInputSlotError = (inputName: string): boolean => { | ||
| const nodeValidationErrors = executionStore.lastNodeErrors?.[nodeData.id] | ||
| if (!nodeValidationErrors?.errors) return false | ||
| return nodeValidationErrors.errors.some( | ||
| (err) => | ||
| err.type === 'required_input_missing' && | ||
| err.extra_info?.input_name === inputName | ||
| ) | ||
| } | ||
There was a problem hiding this comment.
The error state is set on the NodeInputSlot, it should be much simpler to get it that way
There was a problem hiding this comment.
Would this be something we could query a store for, if we set it up?
arjansingh
force-pushed
the
fix/input-slot-error-states
branch
from
af441c7 to
eac6b80
Compare
dosubot
bot
added
size:XL
arjansingh
force-pushed
the
fix/input-slot-error-states
branch
3 times, most recently
from
49d8c21 to
5c21b1f
Compare
dosubot
bot
added
size:L
arjansingh
force-pushed
the
fix/input-slot-error-states
branch
from
652d136 to
cf01d9f
Compare
| return hasSlotError.value | ||
| ? 'ring-2 ring-error dark-theme:ring-error ring-offset-0 rounded-full' | ||
| : '' |
There was a problem hiding this comment.
nit: cn handles boolean/undefined/string, so it's pretty common to do condition && 'class list' which is simpler than a ternary with an empty string branch.
| v-memo="[ | ||
| nodeData.inputs?.length, | ||
| nodeData.outputs?.length, | ||
| executionStore.lastNodeErrors | ||
| ]" |
There was a problem hiding this comment.
It's pretty rare that you actually need v-memo. Could you see if it's necessary?
There was a problem hiding this comment.
i actually removed it during debugging but put it back because i figured i'd get chastised for removing it :Joy:
There was a problem hiding this comment.
I think we can remove it, happy to follow on
| const slotColor = computed(() => getSlotColor(props.slotData.type)) | ||
| const slotColor = computed(() => { | ||
| if (hasSlotError.value) { | ||
| return 'var(--color-error)' |
There was a problem hiding this comment.
I don't think this would do anything.
There was a problem hiding this comment.
that's how the dot turns red.
arjansingh
added
the
New Browser Test Expectations
arjansingh
force-pushed
the
fix/input-slot-error-states
branch
from
cf01d9f to
79125a5
Compare
arjansingh
force-pushed
the
fix/input-slot-error-states
branch
from
9bd814c to
eb08928
Compare
dosubot
bot
added
size:M
dosubot
bot
added
size:L
arjansingh
added
New Browser Test Expectations
Summary
Error states were not getting propagated down to the InputSlots from the API Repsonse
I created a provider and injected error state. It seemed like a way better idea than prop drilling or building a composable that only two nodes (
InputSlotandOutputSlot) would need.Changes
The follow are now error code red when an input node has errors:
This treatment was okay after feedback from design.
Screenshots - Error State
┆Issue is synchronized with this Notion page by Unito