Skip to content

Commit 18787c3

Browse files
Copilotaaronpowell
andauthored
Remove npm functionality moved to Aspire 13 (#928)
* Initial plan * Remove AddViteApp and npm-specific functionality (moved to Aspire 13) Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Update comments and tests to reflect npm removal Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Update MONOREPO.md to remove npm references Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Adding missing types * Bad copilot code * Fixing missing namespace * Handling port forwarding * removing more stuff that has been migrated to aspire core * Reworking how package installing is handled * daily update * Adding back the annotation that is no longer moving to core * Forgot to install packages * adding a bunch more annotations to provide enough metadata * Removing old demo apps * Disabling python tests * Removing a testing change * Updating to the latest nightly and dealing with type name changes * Removing type that was can repurpose from aspire core * breaking the tests down so they are easier to read * Removing legacy docs * Fixing failing tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> Co-authored-by: Aaron Powell <me@aaron-powell.com>
1 parent 021a7ae commit 18787c3

File tree

76 files changed

+1011
-13133
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

76 files changed

+1011
-13133
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,5 @@ nuget
1515

1616
*.binlog
1717
/examples/rust/actix_api/target
18+
19+
target

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<Nullable>enable</Nullable>
1313

1414
<AspireMajorVersion>13</AspireMajorVersion>
15-
<AspireVersion>$(AspireMajorVersion).0.0-preview.1.25523.9</AspireVersion>
15+
<AspireVersion>$(AspireMajorVersion).0.0-preview.1.25531.6</AspireVersion>
1616
<AspireAppHostSdkVersion>$(AspireVersion)</AspireAppHostSdkVersion>
1717
<AspirePreviewSuffix>preview.1.25474.7</AspirePreviewSuffix>
1818
<AspNetCoreVersion>9.0.0</AspNetCoreVersion>

examples/nodejs-ext/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.AppHost/Program.cs

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,22 @@
11
var builder = DistributedApplication.CreateBuilder(args);
22

3-
builder.AddViteApp("vite-demo")
4-
.WithNpmPackageInstallation()
5-
.WithHttpHealthCheck();
6-
7-
builder.AddViteApp("yarn-demo", packageManager: "yarn")
8-
.WithYarnPackageInstallation()
9-
.WithHttpHealthCheck();
10-
11-
builder.AddViteApp("pnpm-demo", packageManager: "pnpm")
12-
.WithPnpmPackageInstallation()
13-
.WithHttpHealthCheck();
14-
15-
// Example of Nx monorepo support - uncomment if you have an Nx workspace
163
var nx = builder.AddNxApp("nx-demo")
17-
.WithNpmPackageInstaller();
4+
.WithNpm(install: true);
185

196
nx.AddApp("blog-monorepo")
20-
.WithHttpEndpoint()
7+
.WithHttpEndpoint(env: "PORT")
218
.WithMappedEndpointPort()
229
.WithHttpHealthCheck();
2310

24-
// Example of Turborepo monorepo support - uncomment if you have a Turborepo workspace
2511
var turbo = builder.AddTurborepoApp("turborepo-demo")
26-
.WithNpmPackageInstaller();
12+
.WithNpm(install: true);
2713

2814
turbo.AddApp("turbo-web", filter: "web")
29-
.WithHttpEndpoint()
15+
.WithHttpEndpoint(env: "PORT")
3016
.WithMappedEndpointPort()
3117
.WithHttpHealthCheck();
3218
turbo.AddApp("turbo-docs", filter: "docs")
33-
.WithHttpEndpoint()
19+
.WithHttpEndpoint(env: "PORT")
3420
.WithMappedEndpointPort()
3521
.WithHttpHealthCheck();
3622

examples/nodejs-ext/pnpm-demo/.gitignore

Lines changed: 0 additions & 24 deletions
This file was deleted.

examples/nodejs-ext/pnpm-demo/README.md

Lines changed: 0 additions & 50 deletions
This file was deleted.

examples/nodejs-ext/pnpm-demo/eslint.config.js

Lines changed: 0 additions & 28 deletions
This file was deleted.

examples/nodejs-ext/pnpm-demo/index.html

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)