- 
                Notifications
    
You must be signed in to change notification settings  - Fork 133
 
Remove npm functionality moved to Aspire 13 #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove npm functionality moved to Aspire 13 #928
Conversation
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
          
 Minimum allowed line rate is   | 
    
| /// Indicates that apps in this monorepo workspace should be executed via a package manager wrapper (e.g., npx, yarn, pnpm). | ||
| /// </summary> | ||
| /// <param name="packageManager">The name of the JavaScript package manager (e.g., "npm", "yarn", "pnpm").</param> | ||
| public sealed class JavaScriptPackageManagerExecutionAnnotation(string packageManager) : IResourceAnnotation | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use https://github.com/dotnet/aspire/blob/main/src/Aspire.Hosting.NodeJs/JavaScriptPackageManagerAnnotation.cs now with the latest builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| 
               | 
          ||
| ```csharp | ||
| builder.AddYarnApp("yarn-demo") | ||
| builder.AddYarnApp("yarn-demo", "../yarn-demo") | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to build AddYarnApp on top of AddJavaScriptApp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's just legacy docs I have to clean up still, it's meant to be replaced by AddJavaScriptApp().WithYarn()
npm support (
AddNpmApp,AddViteApp,WithNpmPackageInstallation) is moving to Aspire.Hosting.NodeJS in Aspire 13 (dotnet/aspire#12283). Yarn and pnpm remain Community Toolkit exclusive.Removed
AddViteApp()- Vite convenience wrapperWithNpmPackageInstallation()- npm package installer for Node appsWithNpmPackageInstaller()- npm installer for Nx/Turborepo monoreposNpmInstallerResource- npm installer resource typeJavaScriptPackageManagerAnnotation/JavaScriptPackageInstallerAnnotation- now provided by AspireRetained (yarn/pnpm)
AddYarnApp()/AddPnpmApp()WithYarnPackageInstallation()/WithPnpmPackageInstallation()WithYarnPackageInstaller()/WithPnpmPackageInstaller()for monoreposYarnInstallerResource/PnpmInstallerResourceMigration
Before:
After (use Aspire.Hosting.NodeJS):
Notes
WithMappedEndpointPort()preserves npm annotation compatibility for Aspire interopImpact: -513 lines (13 files) | npm functionality → Aspire | yarn/pnpm → CT exclusive
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.comdotnet build src/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
AddViteAppandWithNpmPackageInstaller#924💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.