Add OTEL export support to GoFeatureFlag integration #966
+23
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix OTEL export integration in GoFeatureFlags
Add OTEL export support to GoFeatureFlag integration
Nov 12, 2025
Copilot finished work on behalf of
aaronpowell
November 12, 2025 04:13
aaronpowell
requested changes
Nov 12, 2025
Member
aaronpowell
left a comment
aaronpowell
left a comment
There was a problem hiding this comment.
@copilot for the test, assert that it has the OtlpExporterAnnotation annotation and there are environment variables specified here https://github.com/dotnet/aspire/blob/c97743e5f463312ebd2dde2ac454686cc4901a39/src/Aspire.Hosting/OtlpConfigurationExtensions.cs#L62-L110 that can be asserted against.
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Contributor
Author
Updated the test to assert |
Copilot finished work on behalf of
aaronpowell
November 12, 2025 04:35
Copilot finished reviewing on behalf of
aaronpowell
November 12, 2025 05:34
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds OpenTelemetry (OTEL) export support to the GoFeatureFlag integration by calling .WithOtlpExporter() on the resource builder. This enables telemetry export from GoFeatureFlag containers to the Aspire dashboard, addressing the broken OTEL export mentioned in issue #444.
Key changes:
- Added
.WithOtlpExporter()call to the GoFeatureFlag resource builder to enable OTEL support - Added test to verify OtlpExporterAnnotation and EnvironmentCallbackAnnotation are present
- Removed duplicate test with incorrect naming (AddSurrealServerContainerWithLogLevel)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.GoFeatureFlag/GoFeatureFlagBuilderExtensions.cs | Added .WithOtlpExporter() call to enable OpenTelemetry export support |
| tests/CommunityToolkit.Aspire.Hosting.GoFeatureFlag.Tests/AddGoFeatureFlagTests.cs | Added test to verify OTEL annotations are present; removed duplicate test with incorrect naming; added required imports |
Comments suppressed due to low confidence (1)
tests/CommunityToolkit.Aspire.Hosting.GoFeatureFlag.Tests/AddGoFeatureFlagTests.cs:101
- The test method name 'AddSurrealServerContainerWithLogLevelThrowsOnUnsupportedLogLevel' references 'SurrealServer' but is testing GoFeatureFlag functionality. It should be renamed to 'AddGoFeatureFlagWithLogLevelThrowsOnUnsupportedLogLevel' to accurately reflect what it tests.
public void AddSurrealServerContainerWithLogLevelThrowsOnUnsupportedLogLevel(LogLevel logLevel)
tests/CommunityToolkit.Aspire.Hosting.GoFeatureFlag.Tests/AddGoFeatureFlagTests.cs
Outdated
Show resolved
Hide resolved
…ls of aspire Just verifying that we have the annotation should do enough
Member
|
@Odonno took a while but looks like this will finally be working! |
Contributor
Minimum allowed line rate is |
Member
Tracing! |
Odonno
suggested changes
Nov 12, 2025
| [InlineData(LogLevel.Information, "INFO")] | ||
| [InlineData(LogLevel.Warning, "WARN")] | ||
| [InlineData(LogLevel.Error, "ERROR")] | ||
| public async Task AddSurrealServerContainerWithLogLevel(LogLevel logLevel, string? expected) |
| [InlineData(LogLevel.Trace)] | ||
| [InlineData(LogLevel.Critical)] | ||
| [InlineData(LogLevel.None)] | ||
| public void AddSurrealServerContainerWithLogLevelThrowsOnUnsupportedLogLevel(LogLevel logLevel) |
Contributor
There was a problem hiding this comment.
Suggested change
| public void AddSurrealServerContainerWithLogLevelThrowsOnUnsupportedLogLevel(LogLevel logLevel) | |
| public void AddGoFeatureFlagWithLogLevelThrowsOnUnsupportedLogLevel(LogLevel logLevel) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OTEL Support to GoFeatureFlag Integration
This PR adds OpenTelemetry (OTEL) export support to the GoFeatureFlag integration to fix issue #444.
Changes Made:
.WithOtlpExporter()call to the GoFeatureFlag resource builderTechnical Details:
.WithOtlpExporter()toAddGoFeatureFlag()method inGoFeatureFlagBuilderExtensions.cs.WithOtlpExporter()method from Aspire.Hosting SDK automatically configures these variablesOtlpExporterAnnotationandEnvironmentCallbackAnnotationare presentWhat This Fixes:
Test Results:
All 7 unit tests pass successfully
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.