Skip to content

Add OTEL export support to GoFeatureFlag integration #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+24 −26
Open

Add OTEL export support to GoFeatureFlag integration #966

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4e0fee
Initial plan
Copilot Nov 12, 2025
7682748
Add OTEL support to GoFeatureFlag integration
Copilot Nov 12, 2025
b6b0a6a
Add OtlpExporterAnnotation assertion to test as requested
Copilot Nov 12, 2025
7c13f2e
Simplifying the asserts as we don't really need to assert the interna…
aaronpowell Nov 12, 2025
47da676
no need to do async
aaronpowell Nov 12, 2025
6e10991
Update tests/CommunityToolkit.Aspire.Hosting.GoFeatureFlag.Tests/AddG…
aaronpowell Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CommunityToolkit.Aspire.Hosting.GoFeatureFlag/GoFeatureFlagBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ public static IResourceBuilder<GoFeatureFlagResource> AddGoFeatureFlag(
name: GoFeatureFlagResource.PrimaryEndpointName)
.WithHttpHealthCheck("/health")
.WithEntrypoint("/go-feature-flag")
.WithArgs(args);
.WithArgs(args)
.WithOtlpExporter();
}

/// <summary>
Expand Down
43 changes: 20 additions & 23 deletions tests/CommunityToolkit.Aspire.Hosting.GoFeatureFlag.Tests/AddGoFeatureFlagTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.Net.Sockets;
using Aspire.Components.Common.Tests;
using Aspire.Hosting;
using Aspire.Hosting.ApplicationModel;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;

namespace CommunityToolkit.Aspire.Hosting.GoFeatureFlag.Tests;
Expand Down Expand Up @@ -91,29 +94,6 @@ public async Task GoFeatureFlagCreatesConnectionString()
Assert.Equal("Endpoint=http://{goff.bindings.http.host}:{goff.bindings.http.port}", connectionStringResource.ConnectionStringExpression.ValueExpression);
}

[Theory]
[InlineData(LogLevel.Debug, "DEBUG")]
[InlineData(LogLevel.Information, "INFO")]
[InlineData(LogLevel.Warning, "WARN")]
[InlineData(LogLevel.Error, "ERROR")]
public async Task AddSurrealServerContainerWithLogLevel(LogLevel logLevel, string? expected)
Copy link
Contributor

@Odonno Odonno Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deleted?

Copy link
Member

@aaronpowell aaronpowell Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, probably Copilot assuming that it was not relevant as it's named Surreal.

Copy link
Member

@aaronpowell aaronpowell Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you re-introduce this test but rename it to AddGoFeatureFlagServerContainerWithLogLevel

{
var appBuilder = DistributedApplication.CreateBuilder();

var goff = appBuilder
.AddGoFeatureFlag("goff")
.WithLogLevel(logLevel);

using var app = appBuilder.Build();

var config = await goff.Resource.GetEnvironmentVariableValuesAsync();

bool hasValue = config.TryGetValue("LOGLEVEL", out var value);

Assert.True(hasValue);
Assert.Equal(expected, value);
}

[Theory]
[InlineData(LogLevel.Trace)]
[InlineData(LogLevel.Critical)]
Expand All @@ -128,4 +108,21 @@ public void AddSurrealServerContainerWithLogLevelThrowsOnUnsupportedLogLevel(Log

Assert.Throws<ArgumentOutOfRangeException>(func);
}

[Fact]
public void AddGoFeatureFlagAddsOtelAnnotation()
{
var appBuilder = DistributedApplication.CreateBuilder();

var goff = appBuilder.AddGoFeatureFlag("goff");

using var app = appBuilder.Build();

var appModel = app.Services.GetRequiredService<DistributedApplicationModel>();
var resource = Assert.Single(appModel.Resources.OfType<GoFeatureFlagResource>());

// Verify that OTEL environment callback annotation is present (added by WithOtlpExporter)
var envAnnotations = resource.Annotations.OfType<EnvironmentCallbackAnnotation>().ToArray();
Assert.NotEmpty(envAnnotations);
}
}
Loading