-
Notifications
You must be signed in to change notification settings - Fork 81
MarkdownTextBlock improvements #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@niels9001 Looks like it's failing on UWP: Run |
It reinvented the entire sample options pane from scratch and polluted the main sample source code which is displayed to users in the gallery. Instead, it should have:
Existing samples using this setup can be found in the ColorAnalyzer and Media components. This is necessary to keep it easy for devs to copy sample source code from the sample gallery app. |
|
@Arlodotexe See latest changes, it now uses a separate UC following what ColorAnalyzer did. |
MinWidth,MinHeightandStretchforImagewere not working because the code-behind was not leveraging the actual theme, but only listening to the default theme. As a result, setting these properties did nothing.BoldFontWeightas a property; this overrides theFontWeightused for bolded text, default isBoldbut in the Fluent Design typeramp we usually useSemiBoldinstead. With this property apps can override this to make sure their markdown text renders nicely inline with the rest of the UI typeramps.Claude Opus 4.5in VS Code.