Skip to content

adding RangeSpec to picongpu #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

adding RangeSpec to picongpu #5485

wants to merge 3 commits into from

Conversation

@mafshari64
Copy link
Contributor

No description provided.

@PrometheusPi PrometheusPi added CI:no-compile CI is skipping compile/runtime tests but runs PICMI tests PICMI pypicongpu and picmi related labels Sep 25, 2025
@PrometheusPi
Copy link
Member

@mafshari64 Your code does not pass the ci tests. It runs into:

AttributeError: 'RangeSpec' object has no attribute 'get_as_pypicongpu'

@mafshari64
Copy link
Contributor Author

@mafshari64 Your code does not pass the ci tests. It runs into:

AttributeError: 'RangeSpec' object has no attribute 'get_as_pypicongpu'

I know Richard. I am solving it.

PrometheusPi
PrometheusPi reviewed Oct 1, 2025
View reviewed changes
lib/python/picongpu/picmi/diagnostics/rangespec.py Outdated
)

# Check for empty ranges after processing
dummy_sim_box = tuple(20 for _ in range(len(self.ranges))) # Match number of dimensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 20 here?

@PrometheusPi
Copy link
Member

@mafshari64 Could you add such a RangeSpec call in a suitable spot in either the Laser Wakefield or warm plasma PICMI example, so that there is an example for the usage?

@mafshari64
Copy link
Contributor Author

@PrometheusPi, today I updated it to avoid such hardcoding. I will push PR today.

@PrometheusPi
Copy link
Member

@mafshari64 last week you wrote that you will push "today".
Is this now outdated and we can close this PR or are you going to add some changes in the future?

@mafshari64
update rangespec
ee02a32 
ci: no-compile
@mafshari64
Copy link
Contributor Author

@mafshari64 last week you wrote that you will push "today". Is this now outdated and we can close this PR or are you going to add some changes in the future?

@PrometheusPi, in the evening, I was updating and have now pushed it.

@chillenzer chillenzer marked this pull request as draft October 9, 2025 05:32
@chillenzer
Copy link
Contributor

Putting this into draft mode because this interacts with upcoming openPMD development.

@mafshari64
Copy link
Contributor Author

mafshari64 commented Oct 9, 2025 •
edited
Loading

Ok.

@mafshari64 mafshari64 closed this Oct 9, 2025
@mafshari64 mafshari64 reopened this Oct 9, 2025
@mafshari64
Copy link
Contributor Author

@chillenzer, I ran a simple test with this PR and it works. we can check together and if agree then you can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PrometheusPi PrometheusPi PrometheusPi left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CI:no-compile CI is skipping compile/runtime tests but runs PICMI tests PICMI pypicongpu and picmi related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mafshari64 @PrometheusPi @chillenzer