prevent the number of eligible votes from changing during a vote #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check one:
Summary of change(s):
Fixes an edge case where the number of people eligible to vote on an issue might? be able to change during the execution of the vote.
Does not fix the issue raised by @jabbate19. My interpretation is that the Intro Evaluation is a vote to extend an offer of active membership, as opposed to an immediate granting of active membership, so I don't see an issue there. I wouldn't be against an additional amendment to make that part more clear, however.
Please note that with these changes, quorum does not change during the duration of a vote either, since it is a fraction of the number of eligible votes.