Skip to content

Commit 9ffc2bf

Browse files
Fix MP listing in Membership Eval Slideshow
1 parent 9daf8c3 commit 9ffc2bf

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

conditional/blueprints/spring_evals.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,14 @@ def get_cm_count(member_id):
8989
MajorProject.uid == uid)]
9090
}
9191
member['major_projects_len'] = len(member['major_projects'])
92+
member['major_project_passed'] = [
93+
{
94+
'name': p.name,
95+
'status': p.status,
96+
'description': p.description
97+
} for p in MajorProject.query.filter(MajorProject.uid == uid)
98+
if p.status == "Passed"]
99+
member['major_projects_passed_len'] = len(member['major_projects_passed'])
92100
member['major_project_passed'] = False
93101
for mp in member['major_projects']:
94102
if mp['status'] == "Passed":

conditional/templates/spring_eval_slideshow.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@ <h3>{{m['house_meetings_missed']|length}}</h3>
3131
</div>
3232
</div>
3333
<div class="col-xs-12 col-md-4">
34-
{% set major_projects_passed = m['major_projects_len'] >= 1 %}
35-
<div class="item{% if major_projects_passed %} passed{% endif %}">
36-
<span class="icon glyphicon glyphicon-{% if major_projects_passed %}ok passed{%else%}remove{% endif %}" aria-hidden="true"></span>
37-
<h3>{{m['major_projects_len']}}</h3>
34+
{% set major_projects_passed = m['major_projects_passed_len'] >= 1 %}
35+
<div class="item{% if major_projects_passed_len %} passed{% endif %}">
36+
<span class="icon glyphicon glyphicon-{% if major_projects_passed_len %}ok passed{%else%}remove{% endif %}" aria-hidden="true"></span>
37+
<h3>{{m['major_projects_passed_len']}}</h3>
3838
<p>Major Projects</p>
3939
</div>
4040
</div>
4141
</div>
4242
<h4>Major Projects:
43-
{% for i in range(m['major_projects_len']) %}
44-
{{ m['major_projects'][i]['name'] }}{% if i < m['major_projects_len'] - 1 %}, {% endif %}
43+
{% for i in range(m['major_projects_passed_len']) %}
44+
{{ m['major_projects_passed'][i]['name'] }}{% if i < m['major_projects_passed_len'] - 1 %}, {% endif %}
4545
{% endfor %}
4646
</h4>
4747

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ structlog
99
flask_sqlalchemy
1010
flask_migrate
1111
pylint
12-
psycopg2
12+
#psycopg2
1313
raven[flask]

0 commit comments

Comments
 (0)