Ganache fork of mainnet 'corrupts' accounts[0] causing truffle deployment failure

[msuscens]

Hi @davidmurdoch,

Recently when runing ganache to fork mainnet my project's migration script fails. However it still works as expected using ganache without -f option. With the -f option it seems to be changing accounts[0] part-way through the complete migration!?? Shall I raise this as an issue?

My migration script contains the following:

....
     const loanBook = await LoanBook.deployed()
     const eggToken = await EggToken.deployed()

    // DEBUG
    const owner = await eggToken.owner()
    console.log("*** DEBUG for truffle migrate using ganache with -f option")
    console.log(`eggToken.owner() = ${owner}`)
    console.log(`     accounts[0] = ${accounts[0]}`)

    await eggToken.setLoanBook(loanBook.address, {from: accounts[0]})
    console.log("*** END DEBUG: Must pass here!")

When I start ganache with -f option, ie:
$ ganache -h 127.0.0.1 -p 8545 -m "quick brown fox jumped over the lazy dog" -f --miner.timestampIncrement 13

Resulting in ganache startup output of:

ganache v7.4.3 (@ganache/cli: 0.5.3, @ganache/core: 0.5.3)
Starting RPC server

Available Accounts
==================
(0) 0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4 (1000 ETH)
.....

$ truffle migrate --reset
I get the following output (from my failing script) . NOTE: accounts[0] has changed adddress (from before)!!!

8_marketplace_register_tokens.js
================================
*** DEBUG for truffle migrate using ganache with -f option
eggToken.owner() = 0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
     accounts[0] = 0x81c5Fe8fF91901b26497EEaf6597cbbde2840181

Exiting: Review successful transactions manually by checking the transaction hashes above on Etherscan.

Transaction: 0x040b5322f3fac75d672f78a9f98b9fdfa516e426fb98cb299247ab05ec74490f exited with an error (status 0). Reason given: Ownable: caller is not the owner.
     Please check that the transaction:
     - satisfies all conditions set by Solidity `require` statements.
     - does not trigger a Solidity `revert` statement.

Truffle v5.5.3 (core: 5.5.3)
Node v14.15.5

Note: All prior migration scripts execute successfully (incl. deployment of Eggtoken and LoanBook contracts).
Here's the output from the script that deploys the eggToken (when using ganache with -f option):

5_eggToken_migration.js
=======================

   Deploying 'EggToken'
   --------------------
   > block number:        15795091
   > block timestamp:     1666338475
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.77371856869981305
   > gas used:            3690135 (0x384e97)
   > gas price:           6.602965076 gwei
   > value sent:          0 ETH
   > total cost:          0.02436583253072526 ETH

   Deploying 'TransparentUpgradeableProxy'
   ---------------------------------------
   > block number:        15795092
   > block timestamp:     1666338477
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.769095544677817718
   > gas used:            743698 (0xb5912)
   > gas price:           6.216265234 gwei
   > value sent:          0 ETH
   > total cost:          0.004623024021995332 ETH

        Completed EggToken deployment
   -------------------------------------
   > Total cost:     0.028988856552720592 ETH

Now when I start again, but with ganache without the -f option, ie.

$ ganache -h 127.0.0.1 -p 8545 -m "quick brown fox jumped over the lazy dog" --miner.timestampIncrement 13
Resulting in ganache startup out of:

ganache v7.4.3 (@ganache/cli: 0.5.3, @ganache/core: 0.5.3)
Starting RPC server

Available Accounts
==================
(0) 0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4 (1000 ETH)
.....

$ truffle migrate --reset

My deployment scripts all run fine (without erroe), with output (of previously failing script) of:

8_marketplace_register_tokens.js
================================
eggToken.owner() = 0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
     accounts[0] = 0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
*** DEBUG: Should reach here if eggToken.setLoanBook() above completes!
Added DragonToken support ('For Sale or Rent') into Marketplace
   > Saving migration to chain.
   -------------------------------------
   > Total cost:                   0 ETH

I'm running on a MacBookPro (2021).

$truffle version

Truffle v5.5.3 (core: 5.5.3)
Ganache v7.0.1
Solidity - 0.8.17 (solc-js)
Node v14.15.5
Web3.js v1.5.3

[MicaiahReid]

This seems like a bug to me! Do you have a repository available to reproduce this?

[msuscens]

Not a repository I can share openly (it's quite a large project).

However, I also notice that I get a "Ganache forking only supports EIP-1193-compliant providers." compile warning when I use the ganache -f option (but not without it). I don't believe I was receiving that warning a month ago when using the -f option (and indeed the migration script ran fine). I didn't mention this above, but both issues appeared at the same time.

Additionally, an early version of my code (from about a month ago), which I'm sure previously ran without this warning or indeed the migration failure, now gives the warning and migration error.

`% truffle migrate --reset --network development

Compiling your contracts...

Compiling ./contracts/CTokenInterface.sol
Compiling ./contracts/DnaToken.sol
Compiling ./contracts/DragonLibrary.sol
Compiling ./contracts/DragonToken.sol
Compiling ./contracts/DragonTokenV2.sol
Compiling ./contracts/ERC721PagingUpgradeable.sol
Compiling ./contracts/ERC721RentableUpgradeable.sol
Compiling ./contracts/EggToken.sol
Compiling ./contracts/ICEth.sol
Compiling ./contracts/IDnaToken.sol
Compiling ./contracts/IDragonToken.sol
Compiling ./contracts/IEggToken.sol
Compiling ./contracts/ILoanBook.sol
Compiling ./contracts/IMarketplace.sol
Compiling ./contracts/LoanBook.sol
Compiling ./contracts/Marketplace.sol
Compiling ./contracts/MarketplaceV2.sol
Compiling ./contracts/Migrations.sol
Compiling ./contracts/PagingUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol
Compiling @openzeppelin/contracts-upgradeable/security/PausableUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/token/ERC721/ERC721Upgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/token/ERC721/IERC721ReceiverUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/token/ERC721/IERC721Upgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/token/ERC721/extensions/ERC721EnumerableUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/token/ERC721/extensions/IERC721EnumerableUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/token/ERC721/extensions/IERC721MetadataUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/token/ERC721/utils/ERC721HolderUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/utils/AddressUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/utils/StringsUpgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/utils/introspection/ERC165Upgradeable.sol
Compiling @openzeppelin/contracts-upgradeable/utils/introspection/IERC165Upgradeable.sol
Compiling @openzeppelin/contracts/token/ERC20/IERC20.sol
Artifacts written to /Users/Mark/Documents/BlockChain/Projects/Dragon-Masters/build/contracts
Compiled successfully using:

• solc: 0.8.17+commit.8df45f5f.Emscripten.clang
  WARNING: Ganache forking only supports EIP-1193-compliant providers. Legacy support for send is currently enabled, but will be removed in a future version without a breaking change. To remove this warning, switch to an EIP-1193 provider. This error is probably caused by an old version of Web3's HttpProvider (or ganache < v7)`

[davidmurdoch]

Do you need to run truffle migrate --reset --network <whatever your external ganache network is called in your truffle config>?

[msuscens]

I get exactly the same result when I run:
$ truffle migrate --reset --network development

My truffle_config.js contains:

networks: {
    // Useful for testing. The `development` name is special - truffle uses it by default
    // if it's defined here and no other network is specified at the command line.
    // You should run a client (like ganache-cli, geth or parity) in a separate terminal
    // tab if you use this network and you must also set the `host`, `port` and `network_id`
    // options below to some value.
    //
    development: {
      host: "127.0.0.1",     // Localhost (default: none)
      port: 8545,            // Standard Ethereum port (default: none)
      network_id: "*",        // Any network (default: none)
      // gas: 6721975,          // Gas limit copied from ganache-cli run output
      // gasPrice: 20000000000  // Gas price copied from ganache-cli run output
      disableConfirmationListener: true,  // Workaround-fix for 'truffle test' with ganache-cli run error:
                                          // "ProviderError: Could not connect to your Ethereum client with the following parameters: ..."
    },
...etc

[msuscens]

Here's the full output form: truffle migrate --reset --network development

Compiling your contracts...
===========================
> Compiling ./contracts/CTokenInterface.sol
> Compiling ./contracts/DnaToken.sol
> Compiling ./contracts/DragonLibrary.sol
> Compiling ./contracts/DragonToken.sol
> Compiling ./contracts/DragonTokenV2.sol
> Compiling ./contracts/ERC721PagingUpgradeable.sol
> Compiling ./contracts/ERC721RentableUpgradeable.sol
> Compiling ./contracts/EggToken.sol
> Compiling ./contracts/ICEth.sol
> Compiling ./contracts/IDnaToken.sol
> Compiling ./contracts/IDragonToken.sol
> Compiling ./contracts/IEggToken.sol
> Compiling ./contracts/ILoanBook.sol
> Compiling ./contracts/IMarketplace.sol
> Compiling ./contracts/LoanBook.sol
> Compiling ./contracts/Marketplace.sol
> Compiling ./contracts/MarketplaceV2.sol
> Compiling ./contracts/Migrations.sol
> Compiling ./contracts/PagingUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol
> Compiling @openzeppelin/contracts-upgradeable/security/PausableUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/token/ERC721/ERC721Upgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/token/ERC721/IERC721ReceiverUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/token/ERC721/IERC721Upgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/token/ERC721/extensions/ERC721EnumerableUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/token/ERC721/extensions/IERC721EnumerableUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/token/ERC721/extensions/IERC721MetadataUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/token/ERC721/utils/ERC721HolderUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/utils/AddressUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/utils/StringsUpgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/utils/introspection/ERC165Upgradeable.sol
> Compiling @openzeppelin/contracts-upgradeable/utils/introspection/IERC165Upgradeable.sol
> Compiling @openzeppelin/contracts/token/ERC20/IERC20.sol
> Artifacts written to /Users/Mark/Documents/BlockChain/Projects/Dragon-Masters/build/contracts
> Compiled successfully using:
   - solc: 0.8.17+commit.8df45f5f.Emscripten.clang
WARNING: Ganache forking only supports EIP-1193-compliant providers. Legacy support for send is currently enabled, but will be removed in a future version _without_ a breaking change. To remove this warning, switch to an EIP-1193 provider. This error is probably caused by an old version of Web3's HttpProvider (or ganache < v7)


Migrations dry-run (simulation)
===============================
> Network name:    'development-fork'
> Network id:      1
> Block gas limit: 30000000 (0x1c9c380)


1_initial_migration.js
======================

Starting Migrations...

   Deploying 'Migrations'
   ----------------------
   > block number:        15798658
   > block timestamp:     1666381737
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.99369993291755608
   > gas used:            155222 (0x25e56)
   > gas price:           40.58746236 gwei
   > value sent:          0 ETH
   > total cost:          0.00630006708244392 ETH

   -------------------------------------
   > Total cost:     0.00630006708244392 ETH


2_loanBook__migration.js
========================

   Deploying 'LoanBook'
   --------------------
   > block number:        15798660
   > block timestamp:     1666381740
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.825669288043472728
   > gas used:            5246207 (0x500cff)
   > gas price:           31.716529626 gwei
   > value sent:          0 ETH
   > total cost:          0.166391479739628582 ETH


   Deploying 'ProxyAdmin'
   ----------------------
   > block number:        15798661
   > block timestamp:     1666381741
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.811467287863454548
   > gas used:            484020 (0x762b4)
   > gas price:           29.341763109 gwei
   > value sent:          0 ETH
   > total cost:          0.01420200018001818 ETH


   Deploying 'TransparentUpgradeableProxy'
   ---------------------------------------
   > block number:        15798662
   > block timestamp:     1666381743
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.793431651883984972
   > gas used:            691158 (0xa8bd6)
   > gas price:           26.094808972 gwei
   > value sent:          0 ETH
   > total cost:          0.018035635979469576 ETH

Completed LoanBook deployment, configured with:
        Compound cETH contract: 0x4Ddc2D193948926D02f9B1fE9e1daa0718270ED5
        MIN_NONZERO_LOAN_DEPOSIT_WEI = 250000000000000000
        MIN_LOAN_DURATION_SECONDS = 0
   -------------------------------------
   > Total cost:     0.198629115899116338 ETH


3_marketplace_migration.js
==========================

   Deploying 'Marketplace'
   -----------------------
   > block number:        15798664
   > block timestamp:     1666381744
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.697981562942981917
   > gas used:            4581475 (0x45e863)
   > gas price:           20.688637389 gwei
   > value sent:          0 ETH
   > total cost:          0.094784474981768775 ETH


   Deploying 'TransparentUpgradeableProxy'
   ---------------------------------------
   > block number:        15798665
   > block timestamp:     1666381746
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.684550120290131657
   > gas used:            702868 (0xab994)
   > gas price:           19.109480945 gwei
   > value sent:          0 ETH
   > total cost:          0.01343144265285026 ETH

Completed Marketplace deployment:
   -------------------------------------
   > Total cost:     0.108215917634619035 ETH


4_dnaToken_migration.js
=======================

   Deploying 'DnaToken'
   --------------------
   > block number:        15798667
   > block timestamp:     1666381747
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.621723014473861587
   > gas used:            4072940 (0x3e25ec)
   > gas price:           15.30524449 gwei
   > value sent:          0 ETH
   > total cost:          0.0623373424931006 ETH


   Deploying 'TransparentUpgradeableProxy'
   ---------------------------------------
   > block number:        15798668
   > block timestamp:     1666381750
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.608450421303197751
   > gas used:            938708 (0xe52d4)
   > gas price:           14.139213867 gwei
   > value sent:          0 ETH
   > total cost:          0.013272593170663836 ETH

Completed DnaToken deployment:
   -------------------------------------
   > Total cost:     0.075609935663764436 ETH


5_eggToken_migration.js
=======================

   Deploying 'EggToken'
   --------------------
   > block number:        15798670
   > block timestamp:     1666381751
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.565249003795137293
   > gas used:            3727027 (0x38deb3)
   > gas price:           11.493388684 gwei
   > value sent:          0 ETH
   > total cost:          0.042836169946762468 ETH


   Deploying 'TransparentUpgradeableProxy'
   ---------------------------------------
   > block number:        15798671
   > block timestamp:     1666381753
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.557329708284462665
   > gas used:            743698 (0xb5912)
   > gas price:           10.648536786 gwei
   > value sent:          0 ETH
   > total cost:          0.007919295510674628 ETH

Completed EggToken deployment:
   -------------------------------------
   > Total cost:     0.050755465457437096 ETH


6_dragonToken_migration.js
==========================

   Deploying 'DragonLibrary'
   -------------------------
   > block number:        15798673
   > block timestamp:     1666381754
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.545504442255792044
   > gas used:            1314627 (0x140f43)
   > gas price:           8.784622093 gwei
   > value sent:          0 ETH
   > total cost:          0.011548501388254311 ETH


   Linking
   -------
   * Contract: DragonToken <--> Library: DragonLibrary 

   Deploying 'DragonToken'
   -----------------------
   > block number:        15798674
   > block timestamp:     1666381755
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.503013701745663518
   > gas used:            5266646 (0x505cd6)
   > gas price:           8.067893781 gwei
   > value sent:          0 ETH
   > total cost:          0.042490740510128526 ETH


   Deploying 'TransparentUpgradeableProxy'
   ---------------------------------------
   > block number:        15798675
   > block timestamp:     1666381757
   > account:             0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
   > balance:             999.496808235248144474
   > gas used:            814764 (0xc6eac)
   > gas price:           7.616274771 gwei
   > value sent:          0 ETH
   > total cost:          0.006205466497519044 ETH

Completed DragonToken deployment:
   -------------------------------------
   > Total cost:     0.060244708395901881 ETH


7_dragonToken_initialise_growth_matrices.js
===========================================
Initialised Attribute Growth Matrix.
Initialised Base-Skills Growth Matrix.
   -------------------------------------
   > Total cost:                   0 ETH


8_marketplace_register_tokens.js
================================
*** DEBUG for truffle migrate using ganache with -f option
eggToken.owner() = 0xfC1d4eA100c57A6D975eD8182FaAcFD17871a1e4
     accounts[0] = 0x5994D9e224AD2290A83E14f8a62F22dB8bb66637

Exiting: Review successful transactions manually by checking the transaction hashes above on Etherscan.


Transaction: 0xb23485ff9e85bc3aa40e5dd50e569bf235ea55d9ce43c3c9c71c80b2c9df19a4 exited with an error (status 0). Reason given: Ownable: caller is not the owner.
     Please check that the transaction:
     - satisfies all conditions set by Solidity `require` statements.
     - does not trigger a Solidity `revert` statement.

Truffle v5.5.3 (core: 5.5.3)
Node v14.15.5

[davidmurdoch]

Looks like it's using the network named development-fork, not development. Is that something unique to your config?

[davidmurdoch]

Ohhhh, wait. This is attempting a dry run on your already forked ganache, but when truffle creates the dry-run network it uses a different set of accounts, because it can't get the mnemonic from the original chain.

Try running truffle migrate --reset --skipDryRun.

[msuscens]

@MicaiahReid / @davidmurdoch ,

And below is the migration script that deploys the eggToken contract (5_eggToken_migration.js). You can see that eggToken contract is deployed by accounts[0] . And in later migration script ( 8_marketplace_register_tokens.js) I confirm that the eggToken.owner is the original address of accounts[0], but the accounts[0] address has now changed!?

5_eggToken_migration.js

const DnaToken = artifacts.require("DnaToken")
const EggToken = artifacts.require("EggToken")

const EGG_TOKEN_NAME = "Egg (Dragon-Masters)"
const EGG_TOKEN_SYMBOL = "EGG-DM"
const EGG_GEN0_LIMIT = 1000


module.exports = async function (deployer, network, accounts) {

    // Get DnaToken proxy contract (previously deployed)
    const dnaToken = await DnaToken.deployed()

    // Deploy the EggToken (proxy & logic contracts)
    await deployProxy(
        EggToken, 
        [EGG_TOKEN_NAME, EGG_TOKEN_SYMBOL, dnaToken.address, EGG_GEN0_LIMIT], 
        {deployer, initializer: 'init_EggToken', from: accounts[0]}
    )
    console.log("Completed EggToken deployment:")
}```

[davidmurdoch]

(You should use three backticks with quoting multi-line code.)

[davidmurdoch]

Did you see my suggestion here: #3830 (reply in thread)

[msuscens]

@davidmurdoch Yes, I've just tried it and that works! Many thanks!

% truffle migrate --reset --skipDryRun

Warning: possible unsupported (undocumented in help) command line option(s): --skipDryRun

The migration scripts now all run and complete successfully . Furthermore the "WARNING: Ganache forking only supports EIP-1193-compliant providers." no longer appears! :-)

I'm curious as I've never used the option --skipDryRun before when forking mainnet with Ganache. Is the need to use --skipDryRun now due to Ganache v7.4.3?

[davidmurdoch]

No, there should be nothing new to Ganache 7.4.3 that would affect this. Perhaps something in your config has changed, or maybe the truffle version? Here are truffle's release notes: https://github.com/trufflesuite/truffle/releases