Skip to content

Conversation

jb-abbadie
Copy link
Contributor

@jb-abbadie jb-abbadie commented Jan 20, 2025

Description

Update "github.com/pierrec/lz4" to v4

We used non-versionned path that why we had -incompatible in go.mod

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

This was separated from PR in order to keep them simple

Copy link
Collaborator

@mga-chka mga-chka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the PR increases the a dependancy from 2 major versions, it's worth testing the performance & doing a manual end to end test to be sure there is no regression.
(I don't think there are automated tests in the codebase relying on lz4)

@jb-abbadie
Copy link
Contributor Author

Closing because of lack of time in order to perform benchmarks

@jb-abbadie jb-abbadie closed this Feb 12, 2025
@jb-abbadie jb-abbadie deleted the update_lz4 branch February 12, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants