Implement sampler-based dataloading logic#1095
Merged
AntonioCarta merged 1 commit intoContinualAI:masterfrom Jul 18, 2022
Merged
Implement sampler-based dataloading logic#1095AntonioCarta merged 1 commit intoContinualAI:masterfrom
AntonioCarta merged 1 commit intoContinualAI:masterfrom
Conversation
Pull Request Test Coverage Report for Build 2677446091
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how dataloaders are created in
data_loader.py.The new mechanism:
set_epoch. This will be useful in the immediate future to merge the support for distributed training in the main branch.__iter__method. This is needed to manage stateful samplers. The overall length of the final dataloder is computed in the constructor.collate_functions.py. Existing collate functions have been moved there. Aliases have been created indata_loader.py(those aliases will probably be deprecated in the future).collate_functions.pycontains additional functions used to better manage the broadcast of elements while distributed training. They will be useful later!I will remove the related changes from the already opened distributed support PR #996, from which they were taken.