Missing items from last update

Author: CreativeRobotics

src/Commander.cpp

@@ -1,27 +1,15 @@
 #include "Commander.h"
 
 //Initialise the array of internal commands with the constructor
-Commander::Commander(): internalCommandArray ({ "U",
-																								"X",
-																								"?",
-																								"help",
-																								"echo",
-																								"echox",
-																								"errors"}){
+Commander::Commander(){
 	bufferString.reserve(bufferSize);
 	ports.settings.reg = COMMANDER_DEFAULT_REGISTER_SETTINGS;
 	commandState.reg = COMMANDER_DEFAULT_STATE_SETTINGS;
 
 
 }
 //==============================================================================================================
-Commander::Commander(uint16_t reservedBuffer): internalCommandArray ({ 	"U",
-																																				"X",
-																																				"?",
-																																				"help",
-																																				"echo",
-																																				"echox",
-																																				"errors"}){
+Commander::Commander(uint16_t reservedBuffer){
 	//bufferString.reserve(bufferSize);
 	bufferSize = reservedBuffer;
 	bufferString.reserve(bufferSize);
@@ -939,7 +927,7 @@ bool Commander::checkCommand(uint16_t cmdIdx){
 		benchmarkCounter++;
 	#endif
 
-	if(bufferString.length() < (int16_t)commandLengths[cmdIdx]+1) return false; //no match if the buffer is shorter than the command+1 (buffer will have the end of line char)
+	if(bufferString.length() < (int16_t)commandLengths[cmdIdx]+1U) return false; //no match if the buffer is shorter than the command+1 (buffer will have the end of line char)
 	if(commandLengths[cmdIdx] == 1){
 		//This command was a single char, if it is a match then return true if the next char in the buffer is an end of command char (newline, space or delim)
 		if(bufferString.charAt(0) != commandList[cmdIdx].commandString[0]) return false;

src/Commander.h

@@ -504,7 +504,8 @@ class Commander : public Stream {
   uint16_t bytesWritten = 0; //overflow check for bytes written into the buffer
 	uint16_t bufferSize = SBUFFER_DEFAULT;
 	uint16_t dataReadIndex = 0; //for parsing many numbers
-	const char* internalCommandArray[INTERNAL_COMMAND_ITEMS];
+	//const char* internalCommandArray[INTERNAL_COMMAND_ITEMS];
+	const char* internalCommandArray[INTERNAL_COMMAND_ITEMS] = { "U", "X", "?", "help", "echo", "echox", "errors"};
 	String *passPhrase = NULL;
 	String *userString = NULL;
 	uint8_t primntDelayTime = 0; //