Flicker score is doubled

[chj990707]

Description

Theoretically flicker tally should be increased by 5 every time the speed changes from/to zero, or the rotational direction is reversed, as in

Create/src/main/java/com/simibubi/create/content/kinetics/base/KineticBlockEntity.java

Line 183 in 7cdaf89

public void onSpeedChanged(float previousSpeed) {

and since it decreases by 1 every tick, changing the speed every 5 ticks won't cause the block breakage. But as I've experimented with CC:Tweaked and Rotational Speed Controller, changing every 5 ticks(0.25sec sleep) will break it, and the minimal time gap is 0.5 sec(10 ticks). Plus, if I change the speed once every tick to the same direction, it will break very fast.
A reason I can think of is that RSC-or Adjustable Chain Gearshift-will diconnect itself from the power network, and then reconnect to update the stress and speed impact. Which would cause the rotation speed to be zero and then non-zero, adding up 10 flicker tally to the RSC.
I admit this is very trivial case, I discovered this while working with precision directed contraptions. If needed, I will provide a small fix as PR.

Game Log

https://mclo.gs/BKqY0gG

Debug Information

Client Info

Create:
	Mod Version: 6.0.6
	Mod Git Commit: 338bfa0aec952fa51656e8f61bd621ca9b3b2e00
	Ponder Version: 1.0.80
	Forge Version: 47.4.0
	Minecraft Version: 1.20.1

Graphics:
	Flywheel Version: 1.0.4
	Flywheel Backend: flywheel:instancing
	OpenGL Renderer: Intel(R) RaptorLake-S Mobile Graphics Controller
	OpenGL Version: 4.6.0 - Build 32.0.101.6790
	Graphics Mode: fast
	PojavLauncher Detected: false

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 17.0.16, Azul Systems, Inc.
	JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx8192M
	Memory: 2066539120 bytes (1970 MiB) / 3330277376 bytes (3176 MiB) up to 8589934592 bytes (8192 MiB)
	Total Memory: 1272109440 bytes (1213 MiB) / 3330277376 bytes (3176 MiB)
	CPU: 13th Gen Intel(R) Core(TM) i7-13650HX @ 2.80 GHz; 14 cores / 20 threads on 1 socket(s)
	Graphics card #0: Intel(R) UHD Graphics (Intel Corporation (0x8086)); 2048.00 MB of VRAM
	Graphics card #1: NVIDIA GeForce RTX 4060 Laptop GPU (NVIDIA (0x10de)); 4095.00 MB of VRAM

Other Mods:
	Use Item on Block Event: 1.0.0.2
	MixinExtras: 0.4.1
	Create: Radars: 0.3
	Jumbo Furnace: 4.0.0.4
	Create Big Cannons: 5.9.1
	CC:C Bridge: 1.7.1
	Create Diesel Generators: 1.20.1-1.3.5
	Architectury: 9.2.14
	CC: Tweaked: 1.116.1
	More Red x CC:Tweaked Compat: 1.20.1-1.0.0
	Create: CC Total Logistics: 0.3.7
	Kotlin For Forge: 4.11.0
	CC: Androids: 1.3.0
	Create: The Factory Must Grow: 1.0.2c
	More Red: 4.0.0.2
	Tom's Peripherals: 1.3.0
	Ritchie's Projectile Library: 2.1.0

Server Info

Create:
	Mod Version: 6.0.6
	Mod Git Commit: 338bfa0aec952fa51656e8f61bd621ca9b3b2e00
	Ponder Version: 1.0.80
	Forge Version: 47.4.0
	Minecraft Version: 1.20.1

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 17.0.16, Azul Systems, Inc.
	JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx8192M
	Memory: 2066539120 bytes (1970 MiB) / 3330277376 bytes (3176 MiB) up to 8589934592 bytes (8192 MiB)
	Total Memory: 1272109440 bytes (1213 MiB) / 3330277376 bytes (3176 MiB)
	CPU: 13th Gen Intel(R) Core(TM) i7-13650HX @ 2.80 GHz; 14 cores / 20 threads on 1 socket(s)
	Graphics card #0: Intel(R) UHD Graphics (Intel Corporation (0x8086)); 2048.00 MB of VRAM
	Graphics card #1: NVIDIA GeForce RTX 4060 Laptop GPU (NVIDIA (0x10de)); 4095.00 MB of VRAM

Other Mods:
	Use Item on Block Event: 1.0.0.2
	MixinExtras: 0.4.1
	Create: Radars: 0.3
	Jumbo Furnace: 4.0.0.4
	Create Big Cannons: 5.9.1
	CC:C Bridge: 1.7.1
	Create Diesel Generators: 1.20.1-1.3.5
	Architectury: 9.2.14
	CC: Tweaked: 1.116.1
	More Red x CC:Tweaked Compat: 1.20.1-1.0.0
	Create: CC Total Logistics: 0.3.7
	Kotlin For Forge: 4.11.0
	CC: Androids: 1.3.0
	Create: The Factory Must Grow: 1.0.2c
	More Red: 4.0.0.2
	Tom's Peripherals: 1.3.0
	Ritchie's Projectile Library: 2.1.0

[chj990707]

Further experiments with Rotational Speed Controller, Adjustable Chain Gearshift, and Gearshift resulted in following(note: delay times are mislabeled as ticks while it should be seconds).

• Adjustable Chain Gearshift/Gearshift

• Rotational Speed Controller

Since setting Target Speed on Rotational Speed Controller takes one more tick to process, it can be said the result on all 3 blocks follow the same tendency in iterations it takes to break it in successive speed change. Under the hypothesis of 'single speed change always add up 10 flicker tally', the breakage happens when the tally exceeds 128, with the exception of gearshifts breaking at 20 iterations on 0.05 sec(1 tick) delay. Cannot be sure why that happens.
A suggestion I can make is to make a separate method for updating rotation speed from&to non-zero value, which in current code happens by non-zero -> zero -> non-zero requiring 2 calls to updating the kinetic block entity.