Skip to content

Feedback on JOSS Paper #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ijbd opened this issue May 1, 2025 · 0 comments
Open

Feedback on JOSS Paper #22

ijbd opened this issue May 1, 2025 · 0 comments

Comments

@ijbd
Copy link

ijbd commented May 1, 2025

openjournals/joss-reviews#8035

Here is my feedback for the paper:

Paper Review

Statement of Need

  • Seconding @prakaa's comments about which features to (re)prioritize, I think you have a great structure for comparing your software with the existing solutions. In thinking through your edits, you might consider identifying why [your] particular and future research lead(s) to pownet 2.0 filling gaps left by other solutions. This is partially done already by some references in your feature descriptions, but just a note as you edit.
  • Line 36 and 40 "...the ability to efficiently handle large-scale systems with numerous nodes and edges..." and "...specifically designed to run multiple simulations of large-scale power systems..."
    • These are vague functional claims, the second more so than the first. If these are limitiations of existing packages, which of your features responds to these needs? Again, why did/does your research lead you to addressing these?
  • Line 50 "Selecting a set of computationally efficient mathematical formulations is an on-going research Chen et al. (2022)"
    • Change to "research agenda Chen et al. (2022)"?
  • Line 63 "Reservoir simulation"
    • This is a very interesting feature, and all of the relevant studies and publications in the readthedocs appear to explore hydro and energy-water system coupling. Can you elaborate?

Software Design, Implementation, and Validation

  • I don't see a discussion of validation, but former research publications and on-going research count! This could be a good place to list out those projects.
  • Line 67 "The software is specifically designed to support power-water systems coupling"
    • This is another indicator to me that power-water systems coupling should have more emphasis in the statement of need and possibly summary.
@ijbd ijbd changed the title Paper Feedback Feedback on JOSS Paper May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant