Update feature gate logging to include default on #4029
Merged
+61
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the 5.7 release, when AutoUserSchemaCreate was graduated to default on/true, we discovered that our current system (and the underlying featuregate implementation) treats features explicitly turned on by the user differently than features turned on by default. This PR updates that logging to make clear that the features are those specifically requested by the user (kept as a string to help debugging) and revises the 'ShowGates' function to include those set through defaults. Issues: [PGO-1824]
cbandy
approved these changes
Nov 5, 2024
Member
cbandy
left a comment
cbandy
left a comment
There was a problem hiding this comment.
The implementation is good, but I've soured on some of the naming. I misunderstood what "String" did, and now want better method names.
I can do the work of renaming a bunch of things if you're ready to be done with this PR.
cbandy
reviewed
Nov 5, 2024
cbandy
reviewed
Nov 6, 2024
cbandy
reviewed
Nov 6, 2024
| assert.Equal(t, data.BridgeClustersTotal, 2) | ||
| assert.Equal(t, data.PGOClustersTotal, 2) | ||
| assert.Equal(t, data.FeatureGatesEnabled, "TablespaceVolumes=true") | ||
| assert.Equal(t, data.FeatureGatesEnabled, "AutoCreateUserSchema=true,TablespaceVolumes=true") |
Member
There was a problem hiding this comment.
👍🏻 This isn't Contains, but I don't mind seeing the format. 🌱 We can change the test if it is ever a problem.
cbandy
approved these changes
Dec 2, 2024
Co-authored-by: Chris Bandy <chris.bandy@crunchydata.com>
dsessler7
pushed a commit
that referenced
this pull request
Nov 14, 2025
* Update feature gate logging to include default on After the 5.7 release, when AutoUserSchemaCreate was graduated to default on/true, we discovered that our current system (and the underlying featuregate implementation) treats features explicitly turned on by the user differently than features turned on by default. This PR updates that logging to make clear what features are specifically requested by the user and what features are actually enabled (a union of defaults and end user settings). Issues: [PGO-1824] Co-authored-by: Chris Bandy <chris.bandy@crunchydata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
After the 5.7 release, when AutoUserSchemaCreate was graduated to default on/true, we discovered that our current system (and the underlying featuregate implementation) treats features explicitly turned on by the user differently than features turned on by default.
What is the new behavior (if this is a feature change)?
This PR updates that logging to make clear that the features are those specifically requested by the user (kept as a string to help debugging) and revises the 'ShowGates' function to include those set through defaults.
Other Information:
Issues: [PGO-1824]