Update OpenTelemetry and use an internal package #4041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjmoore4
approved these changes
Dec 4, 2024
Contributor
tjmoore4
left a comment
tjmoore4
left a comment
There was a problem hiding this comment.
Looks good to me, a couple of comments but no blockers.
| ctx, span := tracing.Start(ctx, "reconcile-pgupgrade") | ||
| log := logging.FromContext(ctx) | ||
| defer span.End() | ||
| defer func(s tracing.Span) { _ = tracing.Escape(s, err) }(span) |
Contributor
There was a problem hiding this comment.
🤔 This is another place where I am unsure why we're using Escape instead of Check (there are others, but I think it's generally the same question, so I won't mention any more).
Issue: PGO-1954
The "autoexport" and "autoprop" packages import and configure standard exporters according to the current Specification, 1.39.0. The correct correlation of logs to trace context uses underscores now. The "google.golang.org/grpc" module raised its required Go version to 1.22.7 this release but has since reverted that change. The "spancheck" linter reminds us to call "Span.End" after calling "tracing.Start". Issue: PGO-1954 See: https://opentelemetry.io/docs/specs/otel See: https://opentelemetry.io/docs/specs/otel/compatibility/logging_trace_context See: https://www.github.com/open-telemetry/opentelemetry-go/issues/5969
The "spancheck" linter reminds us to call "Span.RecordError" when returning an error. Two functions help with that: "tracing.Check" and "tracing.Escape".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates OpenTelemetry modules and imports them into an
internal/tracingpackage.main()now uses the autoexport and autoprop packages to configure standard exporters according to the current Specification.internal/loggingpackage correlates log messages with spans.Span.EndandSpan.RecordError.Checklist:
Type of Changes:
Other Information:
Issue: PGO-1954