Chunk Serialization #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuddlyBunion341
commented
Nov 6, 2024
| let mut vec = Vec::<BlockId>::new(); | ||
|
|
||
| bytes.iter().for_each(|byte| { | ||
| let symbol_bytes = &byte[0..4]; |
There was a problem hiding this comment.
Todo: Reduce token size
Todo: Handle large tokens (> 4 Bits)
CuddlyBunion341
commented
Nov 7, 2024
CuddlyBunion341
commented
Nov 14, 2024
| vec.push(symbol); | ||
| } | ||
|
|
||
| i += 3; |
CuddlyBunion341
commented
Nov 14, 2024
| let mut i = 0; | ||
| while i < bytes.len() { | ||
| let symbol = bytes[i]; | ||
| let count_bytes = &bytes[i + 1..i + 3]; |
CuddlyBunion341
commented
Nov 14, 2024
| RedTerracotta, | ||
| Terracotta, | ||
| YellowTerracotta, | ||
| macro_rules! enum_from_u8 { |
There was a problem hiding this comment.
I don't plan on learning macros just yet, so this generated stuff is way beyond my understanding but it keeps the enum definition clear. 🪄
CuddlyBunion341
commented
Nov 14, 2024
| } | ||
| } | ||
|
|
||
| impl<'de> Deserialize<'de> for Chunk { |
There was a problem hiding this comment.
Inspired by the deserialization docs:
https://serde.rs/impl-serializer.html
CuddlyBunion341
commented
Dec 5, 2024
|
|
||
| let mut bytes = Vec::<u8>::new(); | ||
| tokens.iter().for_each(|token| { | ||
| let symbol_bytes = token.symbol.to_le_bytes(); |
There was a problem hiding this comment.
le := little endian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement RLE of integer buffers for more efficient data transfer once client/server is rearchitectured.
Inspired by INCO Praktikum @ ZHAW.