-
Notifications
You must be signed in to change notification settings - Fork 0
Add Grass #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Grass #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuddlyBunion341
commented
Mar 8, 2025
CuddlyBunion341
commented
Mar 8, 2025
CuddlyBunion341
commented
Mar 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready
CuddlyBunion341
commented
Mar 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
so... you can finally touch grass now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grass
The landscape was feeling very baren and the next logical step from trees is grass. The grass proposed in this PR consists of a cross mesh with two intersecting grass sprites.
(100% without the use of AI 🎉)
Note
The initial idea with the mesh instancing was too slow and was thus replaced with a more performant approach, having two meshes per chunk, one transparent, the other popaque. All the cross meshes get combined into a single mesh. (b2dc458). Grouping the meshes did not in fact break transparency, which made the optimization possible.
Known Problems
Performance is worse, as meshes are not grouped, this would break transparency(See note above)Notes
Todo
Server
Client
Update raycaster hit location vector when hitting grass-> lets make grass non selectable