Refactor texture definitions #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuddlyBunion341
force-pushed
the
feature/refactor-textures
branch
from
81aa7dc to
5f6f33d
Compare
CuddlyBunion341
commented
Oct 17, 2024
src/client/terrain/util/blocks.rs
Outdated
| } | ||
| type TextureUV = [f32; 2]; | ||
|
|
||
| const AIR_TEXTURE: TextureUV = [-1.0, -1.0]; |
There was a problem hiding this comment.
Use enums instead of explicitly defining constants
| } | ||
|
|
||
| impl TextureManager { | ||
| pub fn new() -> Self { |
There was a problem hiding this comment.
TODO: Introduce cfg files for texture coordinates / dynamic texture atlas generation from texture names
| } | ||
|
|
||
| pub fn create_chunk_mesh(chunk: &Chunk) -> Option<Mesh> { | ||
| pub fn create_chunk_mesh(chunk: &Chunk, texture_manager: &TextureManager) -> Option<Mesh> { |
There was a problem hiding this comment.
Introducing TextureManager resource does increase complexity but at least that shit doesn't need to be hardcoded anymore (the constructor could dynamically set texture coordinates)
CuddlyBunion341
force-pushed
the
feature/refactor-textures
branch
from
5d68c40 to
be5db01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was proposed in #1. It is less flexible but more performant.