apply

Author: hinto-janai

books/user/src/rpc.md

@@ -14,7 +14,7 @@ This section contains the development status of endpoints/methods in `cuprated`.
 |--------|---------|
 | 🟢     | Enabled and tested
 | 🟣     | Enabled but has differences waiting to be resolved
-| 🟠     | Enabled but not tested
+| 🟠     | Enabled but not fully tested
 | ⚪     | Not enabled yet
 | ⚫     | Not planned to be supported
 
@@ -31,11 +31,11 @@ This section contains the development status of endpoints/methods in `cuprated`.
 | `generateblocks`               | ⚪     |
 | `get_alternate_chains`         | ⚪     |
 | `get_bans`                     | ⚪     |
-| `get_block`                    | ⚪     |
-| `get_block_count`              | ⚪     |
-| `get_block_header_by_hash`     | ⚪     |
-| `get_block_header_by_height`   | ⚪     |
-| `get_block_headers_range`      | ⚪     |
+| `get_block`                    | 🟠     |
+| `get_block_count`              | 🟠     |
+| `get_block_header_by_hash`     | 🟠     |
+| `get_block_header_by_height`   | 🟠     |
+| `get_block_headers_range`      | 🟠     |
 | `get_block_template`           | ⚪     |
 | `get_coinbase_tx_sum`          | ⚪     |
 | `get_connections`              | ⚪     |
@@ -48,8 +48,8 @@ This section contains the development status of endpoints/methods in `cuprated`.
 | `get_tx_ids_loose`             | ⚪     | Not implemented in `monerod` release branch yet
 | `get_txpool_backlog`           | ⚪     |
 | `get_version`                  | ⚪     |
-| `hard_fork_info`               | ⚪     |
-| `on_get_block_hash`            | ⚪     |
+| `hard_fork_info`               | 🟠     |
+| `on_get_block_hash`            | 🟠     |
 | `prune_blockchain`             | ⚫     |
 | `relay_tx`                     | ⚪     |
 | `set_bans`                     | ⚪     |
@@ -60,7 +60,7 @@ This section contains the development status of endpoints/methods in `cuprated`.
 | Endpoint                       | Status | Notes   |
 |--------------------------------|--------|---------|
 | `/get_alt_blocks_hashes`       | ⚪     |
-| `/get_height`                  | ⚪     |
+| `/get_height`                  | 🟠     |
 | `/get_limit`                   | ⚪     |
 | `/get_net_stats`               | ⚪     |
 | `/get_outs`                    | ⚪     |

storage/blockchain/src/service/read.rs

@@ -17,6 +17,7 @@ use std::{
 };
 
 use indexmap::{IndexMap, IndexSet};
+use monero_serai::block::Block;
 use rayon::{
     iter::{Either, IntoParallelIterator, ParallelIterator},
     prelude::*,
@@ -54,8 +55,8 @@ use crate::{
         types::{BlockchainReadHandle, ResponseResult},
     },
     tables::{
-        AltBlockHeights, BlockHeights, BlockInfos, OpenTables, RctOutputs, Tables, TablesIter,
-        TxIds, TxOutputs,
+        AltBlockHeights, BlockHeaderBlobs, BlockHeights, BlockInfos, OpenTables, RctOutputs,
+        Tables, TablesIter, TxIds, TxOutputs,
     },
     types::{
         AltBlockHeight, Amount, AmountIndex, BlockHash, BlockHeight, KeyImage, PreRctOutputId,
@@ -888,11 +889,31 @@ fn alt_blocks_in_chain(env: &ConcreteEnv, chain_id: ChainId) -> ResponseResult {
 
 /// [`BlockchainReadRequest::Block`]
 fn block(env: &ConcreteEnv, block_height: BlockHeight) -> ResponseResult {
-    Ok(BlockchainResponse::Block(todo!()))
+    // Single-threaded, no `ThreadLocal` required.
+    let env_inner = env.env_inner();
+    let tx_ro = env_inner.tx_ro()?;
+
+    let block_blob = env_inner
+        .open_db_ro::<BlockHeaderBlobs>(&tx_ro)?
+        .get(&block_height)?;
+
+    let block = Block::read(&mut block_blob.0.as_slice())?;
+
+    Ok(BlockchainResponse::Block(block))
 }
 
 /// [`BlockchainReadRequest::BlockByHash`]
 fn block_by_hash(env: &ConcreteEnv, block_hash: BlockHash) -> ResponseResult {
+    // Single-threaded, no `ThreadLocal` required.
+    let env_inner = env.env_inner();
+    let tx_ro = env_inner.tx_ro()?;
+
+    let tables = env_inner.open_tables(&tx_ro)?;
+    let block_height = tables.block_heights().get(&block_hash)?;
+    let block_blob = tables.block_header_blobs().get(&block_height)?;
+
+    let block = Block::read(&mut block_blob.0.as_slice())?;
+
     Ok(BlockchainResponse::Block(todo!()))
 }