rpc-types: add traits and enum requests/responses
#241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-docs
hinto-janai
commented
Aug 1, 2024
hinto-janai
commented
Aug 1, 2024
Comment on lines
+1572
to
+1586
| /// JSON-RPC requests. | ||
| /// | ||
| /// This enum contains all [`crate::json`] requests. | ||
| /// | ||
| /// See also: [`JsonRpcResponse`]. | ||
| /// | ||
| /// TODO: document and test (de)serialization behavior after figuring out `method/params`. | ||
| #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)] | ||
| #[cfg_attr(feature = "serde", derive(Deserialize, Serialize))] | ||
| #[cfg_attr( | ||
| feature = "serde", | ||
| serde(rename_all = "snake_case", tag = "method", content = "params") | ||
| )] | ||
| #[allow(missing_docs)] | ||
| pub enum JsonRpcRequest { |
There was a problem hiding this comment.
TODO: this is the problematic method/params enum btw. Will fix in another PR.
hinto-janai
changed the title
enum requests/responsesenum requests/responses
Boog900
approved these changes
Aug 1, 2024
Comment on lines
+1560
to
+1561
| GetTxIdsLoose, | ||
|
|
There was a problem hiding this comment.
This is going to be an annoying endpoint to support, it may require DB changes, depending on what guarantees we need to make
There was a problem hiding this comment.
I would probably be ok dropping support for this end point.
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds some types/traits to
cuprate_rpc_types.This adds 6 enums for encapsulating RPC requests/responses:
crate::json::JsonRpcRequest&crate::json::JsonRpcResponsecrate::bin::BinRequest&crate::bin::BinResponsecrate::other::OtherRequest&crate::other::OtherResponse2 traits that contains some metadata about RPC request/responses:
RpcCallRpcCallValueand changes to the type generator macro to auto implement the traits.
Why
Both enum types and metadata is needed for actual RPC usage: #233.
How
See below review.