Skip to content

Conversation

hinto-janai
Copy link
Contributor

What

  • Removes temporary lints from rpc/
  • Fixes dead code, unused imports, etc

@github-actions github-actions bot added the A-rpc Area: Related to RPC. label Aug 9, 2024
@hinto-janai hinto-janai marked this pull request as ready for review August 9, 2024 21:11
@hinto-janai hinto-janai requested a review from Boog900 August 9, 2024 21:11
@hinto-janai hinto-janai mentioned this pull request Aug 9, 2024
25 tasks
@hinto-janai hinto-janai added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 10, 2024
// TODO
rustdoc::bare_urls,
clippy::multiple_crate_versions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the indenting is different here, I think the other lints are incorrect though not this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess rustfmt doesn't work inside #![], fixed in other crates too.

@github-actions github-actions bot added the A-storage Area: Related to storage. label Aug 20, 2024
@hinto-janai hinto-janai requested a review from Boog900 August 20, 2024 20:24
@Boog900 Boog900 merged commit 5648bf0 into Cuprate:main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Related to RPC. A-storage Area: Related to storage. C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants