Replace OnceLock + fn with LazyLock
#256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-test-utils
Boog900
requested changes
Aug 16, 2024
| DECOMPOSED_AMOUNTS.get_or_init(|| { | ||
| [ | ||
| /// Decomposed amount table. | ||
| pub static DECOMPOSED_AMOUNTS: LazyLock<[u64; 172]> = LazyLock::new(|| { |
There was a problem hiding this comment.
Can we remove the LazyLock here, keep it a static though. I don't know why I made this a OnceLock, the data is still in the binary.
There was a problem hiding this comment.
I must say I'm confused on why this isn't a const
There was a problem hiding this comment.
static is a ref to 1 memory address containing the data, const inlines the data everywhere it gets used.
I assume @Boog900 doesn't want it inlined in the binary everywhere it gets used.
There was a problem hiding this comment.
I was confused, I thought const weren't inlined. Thanks for the heads-up
Boog900
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #236.
This replaces the
OnceLock+fns that were used in aLazyLocktype of way for the entire codebase. There's otherOnceLocks remaining but they are used differently.