lints: opt in manual lint crates #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-dependency
27 tasks
Boog900
reviewed
Sep 2, 2024
storage/blockchain/src/config/mod.rs
Outdated
Comment on lines
43
to
45
| #[allow(clippy::module_inception)] | ||
| mod config; | ||
| pub use config::{Config, ConfigBuilder, ReaderThreads}; |
There was a problem hiding this comment.
This one seems like a mistake, I think I did this when I moved ReaderThreads, we could move the config sub-module into this module.
storage/blockchain/src/lib.rs
Outdated
Comment on lines
3
to
4
| // See `cuprate-database` for reasoning. | ||
| clippy::significant_drop_tightening |
storage/database/src/lib.rs
Outdated
Comment on lines
3
to
15
| // This lint is allowed because the following | ||
| // code exists a lot in this crate: | ||
| // | ||
| // ```rust | ||
| // let env_inner = env.env_inner(); | ||
| // let tx_rw = env_inner.tx_rw()?; | ||
| // OpenTables::create_tables(&env_inner, &tx_rw)?; | ||
| // ``` | ||
| // | ||
| // Rust thinks `env_inner` can be dropped earlier | ||
| // but it cannot, we need it for the lifetime of | ||
| // the database transaction + tables. | ||
| clippy::significant_drop_tightening |
storage/txpool/src/lib.rs
Outdated
Comment on lines
3
to
4
| // See `cuprate-database` for reasoning. | ||
| clippy::significant_drop_tightening |
Boog900
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cargo.tomlWhere
Crates affected:
rpc/{interface,json-rpc,types}storage/{blockchain,database,txpool}helper/types/