helper: add and use cast module
#264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-dependency
github-actions
bot
added
A-workspace
hinto-janai
commented
Sep 2, 2024
Comment on lines
-117
to
+119
| let body_len = head | ||
| .size | ||
| .try_into() | ||
| .map_err(|_| BucketError::BucketExceededMaxSize)?; | ||
| let body_len = u64_to_usize(head.size); |
There was a problem hiding this comment.
I know there's a max bucket size but I'm pretty sure this isn't that - it would have allowed u64::MAX before since this is u64::try_into -> usize.
There was a problem hiding this comment.
Yeah this was for 32-bit targets, size is a field sent over the network so we can't panic here
| LevinCommand::GetTxPoolCompliment => 1024 * 1024 * 4, // 4 MB | ||
|
|
||
| LevinCommand::Unknown(_) => usize::MAX.try_into().unwrap_or(u64::MAX), | ||
| LevinCommand::Unknown(_) => u64::MAX, |
There was a problem hiding this comment.
Not a cast but if we are only supporting 64-bit this is always u64::MAX.
Boog900
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a
cuprate_helper::castmodule and uses it throughout the codebase.Closes #167.