-
Notifications
You must be signed in to change notification settings - Fork 49
book/architecture: add resource index #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Index of threads | ||
This is an index of all of the system threads Cuprate actively uses. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, is this just global rayon
+ global tokio
+ blockchain
+ txpool
?
@Boog900 are there any threads (ephemeral/persistent) spawned in any of your code? Or any code that we call out to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to have a thread that listens to Stdin and handles commands. Also the blockchain
+ txpool
will use the same threadpool
# Index of ports | ||
This is an index of all of the network sockets Cuprate actively uses. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we open any right now, right? Maybe networking ones in the alpha binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not yet, we would need #176. For the initial alpha binary I would be ok with not accepting inbound connections
@@ -0,0 +1,87 @@ | |||
# Index of PATHs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we only save database files currently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also save a p2p_state
file, which I should add to helper
What
Adds an index section for common resources in the
Resources
section, similar to the crates index we already have.Setting this up now and gradually editing it is probably easier than doing it all at once.