P2P: Implement incoming ping request handling over maximum inbound limit #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boog900
requested changes
Sep 9, 2024
p2p/p2p/src/inbound_server.rs
Outdated
| .instrument(Span::current()) | ||
| ); | ||
|
|
||
| task.await.expect("A tokio task responsible for handling ping requests panicked!"); |
There was a problem hiding this comment.
By awaiting the task here we block the inbound server from processing other connections.
I would recommend spawning these tasks on a JoinSet and checking the length to limit concurrent pings instead of using a semaphore.
There was a problem hiding this comment.
Fixed in latest commit.
Boog900
reviewed
Sep 9, 2024
Boog900
reviewed
Sep 9, 2024
Asurar0
force-pushed
the
handle_incoming_ping
branch
from
74436e6 to
ce2b990
Compare
- If the maximum inbound connection semaphore reach its limit, `inbound_server` fn will open a tokio task to check if the node wanted to ping us. If it is the case we respond, otherwise drop the connection. - Added some documentation to the `inbound_server` fn.
Asurar0
force-pushed
the
handle_incoming_ping
branch
from
ce2b990 to
29faf34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes: #176
This PR implements the following changes:
inbound_serverfn will open a tokio task to check if the node wanted to ping us. If it is the case we respond, otherwise drop the connection.inbound_serverfn.