Skip to content

Storage: use saturating_add for cumulative_generated_coins #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2024
Merged

Storage: use saturating_add for cumulative_generated_coins #275

merged 2 commits into from
Sep 10, 2024

Conversation

Boog900
Copy link
Member

@Boog900 Boog900 commented Sep 9, 2024

Why

This amount overflows due to tail emission, the consensus cache already does this.

@Boog900 Boog900 requested a review from hinto-janai September 9, 2024 21:11
@github-actions github-actions bot added the A-storage Area: Related to storage. label Sep 9, 2024
hinto-janai
hinto-janai approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@hinto-janai hinto-janai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... what does monerod actually store here? u64::MAX?

Then it returns something like u64::MAX + calculate_cumulative_tail_emission()?

@Boog900 Boog900 merged commit 49d1344 into main Sep 10, 2024
6 checks passed
@Boog900 Boog900 deleted the db-generated-coins branch September 10, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hinto-janai hinto-janai hinto-janai approved these changes

Assignees

No one assigned

Labels

A-storage Area: Related to storage.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boog900 @hinto-janai