Skip to content

as -> cuprate_helper::cast #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

as -> cuprate_helper::cast #333

wants to merge 6 commits into from

Conversation

hinto-janai
Copy link
Contributor

What

Replaces some leftover as casts with cuprate_helper::cast functions throughout the codebase.

Why

#167

@github-actions github-actions bot added A-dependency Area: Related to dependencies, or changes to a Cargo.{toml,lock} file. A-workspace Area: Changes to a root workspace file or general repo file. A-consensus Area: Related to consensus. A-storage Area: Related to storage. A-pruning Area: Related to pruning. labels Nov 1, 2024
@hinto-janai hinto-janai marked this pull request as ready for review November 1, 2024 14:03
@hinto-janai hinto-janai requested a review from Boog900 November 1, 2024 14:03
@github-actions github-actions bot added A-p2p Area: Related to P2P. A-test-utils Area: Related to test-utils. A-cryptonight Area: Related to Cryptonight. A-helper Area: Related to cuprate-helper. A-net Area: Related to networking. A-types Area: Related to types. A-rpc Area: Related to RPC. A-constants Area: Related to constants. labels Nov 12, 2024
@github-actions github-actions bot removed A-p2p Area: Related to P2P. A-test-utils Area: Related to test-utils. A-cryptonight Area: Related to Cryptonight. A-helper Area: Related to cuprate-helper. A-net Area: Related to networking. A-types Area: Related to types. A-rpc Area: Related to RPC. A-constants Area: Related to constants. labels Nov 12, 2024
@hinto-janai hinto-janai added the P-low Priority: Low. label Dec 3, 2024
@hinto-janai hinto-janai marked this pull request as draft December 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boog900 Boog900 Awaiting requested review from Boog900

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-consensus Area: Related to consensus. A-dependency Area: Related to dependencies, or changes to a Cargo.{toml,lock} file. A-pruning Area: Related to pruning. A-storage Area: Related to storage. A-workspace Area: Changes to a root workspace file or general repo file. P-low Priority: Low.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hinto-janai