-
Notifications
You must be signed in to change notification settings - Fork 49
rpc/types 32 bit support #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm 👍 I managed to construct a request object for get_blocks.bin with this branch. some observations regarding the types: First I used GetBlocksRequest::default() to construct the request which meant the start_height was set to 0. As a result the finish function gave me: "Required field was not found!" Line 298 in b6c4adc
This is because there are no Blocks in this response. This time this was because of let pool_info_extent = self.pool_info_extent.ok_or(ELSE)?; After I manually inserted let pool_info_extent = PoolInfoExtent::None; the Response was parsed successfully. Suggestions:
EDIT: |
Co-authored-by: hinto-janai <hinto.janai@protonmail.com>
What
Makes changes to some crates to support 32 bit systems for
rpc/types
Why
WASM